Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

未来几个月计划 #128

Closed
3 tasks done
Nambers opened this issue Sep 13, 2022 · 20 comments
Closed
3 tasks done

未来几个月计划 #128

Nambers opened this issue Sep 13, 2022 · 20 comments
Assignees
Labels
f: API 关于:公开API f: structure design 关于:结构设计 p: high 优先级:高 t: enhancement 类型:改进或新特性

Comments

@Nambers
Copy link
Owner

Nambers commented Sep 13, 2022

功能描述

按优先级排序:

  1. 修复新报告的 issue
  1. TBD

原因

None

组件选择

both

@Nambers Nambers added t: enhancement 类型:改进或新特性 f: API 关于:公开API p: high 优先级:高 f: structure design 关于:结构设计 labels Sep 13, 2022
@Antares0982
Copy link
Collaborator

Antares0982 commented Sep 20, 2022

  • 具体的异常类型应该在需要抛出的位置再定义,不要统合到一个exception.h里

@Nambers
Copy link
Owner Author

Nambers commented Sep 20, 2022

TODO1:

Class_cpplib = reinterpret_cast<jclass>(env->NewGlobalRef(env->FindClass("tech/eritquearcus/miraicp/shared/CPPLib")));

改成

Class_cpplib = reinterpret_cast<jclass>(env->NewGlobalRef(env->FindClass("tech/eritquearcus/miraicp/shared/CPPLibMultiplatform")));

以及

if (!registerMethods(env, "tech/eritquearcus/miraicp/shared/CPPLib", method_table, 3)) {
if (!registerMethods(env, "tech/eritquearcus/miraicp/shared/CPPLibMultiplatform", method_table, 3)) {

我觉得可以用个宏/常量替换

@Antares0982
Copy link
Collaborator

Antares0982 commented Sep 20, 2022

  • 增加代码规范文档

@wly20040415
Copy link

希望主可以增加一个获取龙王的事件,谢谢啦^_^

@Antares0982
Copy link
Collaborator

  • refresh需要用try包裹,失败后将init设为false

@Nambers Nambers pinned this issue Sep 25, 2022
@Antares0982
Copy link
Collaborator

Antares0982 commented Oct 15, 2022

@Antares0982
Copy link
Collaborator

Antares0982 commented Oct 16, 2022

  • PLUGIN_INFO改为传递指针而非引用,允许返回空指针用于异常检查不允许空指针

@Antares0982
Copy link
Collaborator

Antares0982 commented Oct 16, 2022

  • 保留events原有的构造函数,但改为protected,用作传入json的构造函数的委托构造

@Antares0982
Copy link
Collaborator

Antares0982 commented Oct 16, 2022

  • timeoutEvent改为在libloader线程处理,防止加载多个插件时倒计时被抛到其他插件

@Antares0982
Copy link
Collaborator

Antares0982 commented Oct 29, 2022

  • 加入线程池

@Nambers Nambers mentioned this issue Nov 10, 2022
@Antares0982
Copy link
Collaborator

Antares0982 commented Nov 19, 2022

  • timeoutEvent由libloader端tick处理,降低线程池占用

@Nambers
Copy link
Owner Author

Nambers commented Nov 19, 2022

  • native 收不到包
  • api 文档样式崩坏
  • 重构一些内部实现

@Antares0982
Copy link
Collaborator

Antares0982 commented Nov 21, 2022

  • 插件接口noexcept,是否产生异常通过MiraiCPString int返回

@Antares0982
Copy link
Collaborator

  • 使用md5计算插件hash,并依此作为目标文件名复制temp插件

@Antares0982
Copy link
Collaborator

Antares0982 commented Nov 21, 2022

@Antares0982
Copy link
Collaborator

  • 添加wchar, wstring类型的支持

@Antares0982
Copy link
Collaborator

  • 对所有const json对象,检查其key存在性后再使用

@Antares0982
Copy link
Collaborator

Antares0982 commented Jan 17, 2023

  • 更好的线程识别方案,受限于linux内核,线程名最大字符数为15,需要一些别的方案来存储线程识别符

@Antares0982
Copy link
Collaborator

  • 使用md5计算插件hash,并依此作为目标文件名复制temp插件

用这个 https://github.com/stbrumme/hash-library

@Nambers
Copy link
Owner Author

Nambers commented Oct 26, 2023

no planned anymore ><

@Nambers Nambers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
@Nambers Nambers unpinned this issue Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: API 关于:公开API f: structure design 关于:结构设计 p: high 优先级:高 t: enhancement 类型:改进或新特性
Projects
None yet
Development

No branches or pull requests

3 participants