Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
On some of the older devices the recovery doesn't support metadata when setting permissions. This allows to use set_perm vs set_metadata. Enable this behavior by setting SKIP_SET_METADATA := true Change-Id: Ib6cf97b5ca28cee8a87975231f3a61b156e77d29
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1404,7 +1404,9 @@ ifdef PRODUCT_EXTRA_RECOVERY_KEYS | |
| $(hide) echo "extra_recovery_keys=$(PRODUCT_EXTRA_RECOVERY_KEYS)" >> $(zip_root)/META/misc_info.txt | ||
| endif | ||
| $(hide) echo "mkbootimg_args=$(BOARD_MKBOOTIMG_ARGS)" >> $(zip_root)/META/misc_info.txt | ||
| ifneq ($(SKIP_SET_METADATA),true) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
kasperhettinga
|
||
| $(hide) echo "use_set_metadata=1" >> $(zip_root)/META/misc_info.txt | ||
| endif | ||
| $(hide) echo "update_rename_support=1" >> $(zip_root)/META/misc_info.txt | ||
| $(call generate-userimage-prop-dictionary, $(zip_root)/META/misc_info.txt) | ||
| @# Zip everything up, preserving symlinks | ||
|
|
||
This single change cause a problem for older devices with Recovery that doesn't support set_metadata.
If possible, please take back "ifneq ($(SKIP_SET_METADATA),true)" for support for older devices. Thank you.