Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Migrate remaining projects to support netstandard 1.6 #2606

Closed
22 of 28 tasks
cemremengu opened this issue Oct 31, 2016 · 8 comments
Closed
22 of 28 tasks

Migrate remaining projects to support netstandard 1.6 #2606

cemremengu opened this issue Oct 31, 2016 · 8 comments

Comments

@cemremengu
Copy link
Contributor

cemremengu commented Oct 31, 2016

Description

We will need to update all Nancy packages/project to support netstandard 1.6. In order to achieve this, we may need to update the dependencies for some packages as well. If you need to update the dependencies do so by bumping it to the latest release that supports netstandard.

ℹ️ This task need to be completed before #2612.

TODO

(update this list including to link any pull-requests and check after merged or rejected)

Main project

  • Nancy.Authentication.Basic (Up-to-date)
  • Nancy.Authentication.Forms (Up-to-date)
  • Nancy.Authentication.Stateless (Up-to-date)
  • Nancy.Embedded (Up-to-date)
  • Nancy.Encryption.MachineKey (Not supported on .NET Core)
  • Nancy.Hosting.Aspnet (Not required)
  • Nancy.Hosting.Self (Not required)
  • Nancy.Metadata.Modules (Up-to-date)
  • Nancy.Owin (Not required)
  • Nancy.Validation.DataAnnotations
  • Nancy.Validation.FluentValidation (Up-to-date)
  • Nancy.ViewEngines.DotLiquid (Bumped dotliquid to support netstandard16 #2599)
  • Nancy.ViewEngines.Markdown (update to latest Markdown package #2614)
  • Nancy.ViewEngines.Nustache (Not supported on .NET Core)
  • Nancy.ViewEngines.Spark (Not supported on .NET Core)
  • Nancy.ViewEngines.Razor (Not supported on .NET Core)
  • Nancy.ViewEngines.Razor.BuildProviders (Not supported on .NET Core)

Bootstrappers

  • Nancy.Bootstrappers.Autofac (Up-to-date)
  • Nancy.Bootstrappers.StructureMap (Up-to-date)
  • Nancy.Bootstrappers.Ninject (Not supported on .NET Core)
  • Nancy.Bootstrappers.Unity (Not supported on .NET Core)
  • Nancy.Bootstrappers.Windsor (Not supported on .NET Core)

Serialization

Valid rejection status for each of the projects

  • Up-to-date
  • 3rd-party dependency does not support .NET Core
  • Not supported on .NET Core
  • Not required

Example

  • Nancy.Foo (Not supported on .NET Core)
  • Nancy.Bar (Up-to-date)
  • Nancy.Baz (pull-requests #9999)
@cemremengu cemremengu changed the title Bump subrepo deps and packages to latest and add netstandard16 support Bump all to latest and add netstandard16 support Nov 2, 2016
@perlun
Copy link

perlun commented Nov 5, 2016

Just a stupid question - netstandard16 meaning netstandard1.6, right?

@cemremengu
Copy link
Contributor Author

@perlun Yes

@sphiecoh
Copy link
Contributor

sphiecoh commented Nov 5, 2016

I think Nancy.Hosting.Self can be removed. It will be replaced by Kestrel host.

@thecodejunkie
Copy link
Member

@cemremengu can you please elaborate on this PR a bit more? What does "bump all to latest" mean? All what?
And do we have projects that target netstandard, just not 1.6?

Please maintain this list and link the PRs for each project

@thecodejunkie
Copy link
Member

Here's a sample of an Epic #2000

@thecodejunkie
Copy link
Member

thecodejunkie commented Nov 13, 2016

The categories "packages" and "subrepos" confuses me a bit. They're all packages. The only sub-repo we have is Nancy as seen from other repos

@thecodejunkie
Copy link
Member

Me again 😄

I need this issue to

  • clearly describe the purpose and scope
  • link to pull-requests that are sent in order to help close this
  • descriptive information why some aren't needed: like (already updated), (dependency does not support netstandard yet) and so on
  • have a clear description of how 3rd party dependencies will be bumped. Are we staying withing the minor or are we also considering bumping the major?

@thecodejunkie thecodejunkie changed the title Bump all to latest and add netstandard16 support Bump all to latest and add netstandard1.6 support Nov 13, 2016
@thecodejunkie thecodejunkie changed the title Bump all to latest and add netstandard1.6 support Migrate remaining projects to support netstandard 1.6 Nov 13, 2016
@sphiecoh
Copy link
Contributor

Bootstrappers.Ninject needs to be marked as rejected since it depends on Ninject.Extensions.ChildKernel which is not supported on core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants