This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Added user mapping to Tokenizer #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I would go with IUserIdentityProvider, |
|
Factory is a terrible name for this. I feel it's more of a Resolver than a Provider... The provider is more the implementation rather than... a resolver which is just resolving the user for the request... I think it should be Resolver. |
|
|
||
| using Nancy.Security; | ||
|
|
||
| internal class DefaultUserMapper : IUserMapper |
There was a problem hiding this comment.
Class + members are missing XML comments
|
I think |
|
This should be good to go now 😄 |
thecodejunkie
added a commit
that referenced
this pull request
Aug 3, 2014
Added user mapping to Tokenizer
|
👍 Don't forget the |
|
Excellent, thanks guys. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1566
This PR adds an equivalent to the forms authentication
IUserMapperto allow users to provide a customIUserIdentityimplementation.I'm not sure that
IUserMapperis the best name though, since this doesn't map aGuidto an identity, but rather just creates an identity based on username and claims.Any suggestions?
IUserIdentityFactory?IUserIdentityProvider?IUserIdentityResolver?