This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Fixed JsonDeserializer for new Date format (two unit tests were broken). #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -539,7 +539,7 @@ bool ParseBuffer (out object result) | |||
|
|
|||
| case JsonType.STRING: | |||
| if (s.StartsWith("/Date(", StringComparison.Ordinal) && s.EndsWith(")/", StringComparison.Ordinal)) { | |||
| int tzCharIndex = s.IndexOfAny(new char[] { '+', '-' }); | |||
| int tzCharIndex = s.IndexOfAny(new char[] { '+', '-' }, 7); | |||
There was a problem hiding this comment.
Why not use LastIndexOfAny()? If it because if you had a date without timezone information "/Date(-59011459200000)/" then it would incorrectly pick up the minus at the beginning?
There was a problem hiding this comment.
I did not do it like that because if there is NO timezone it also has to work, and there might be only a negative milliseconds value. So it would again find that minus sign at the beginning of the string. Like this it won't find anything in that case, and that's what we want :-)
thecodejunkie
added a commit
that referenced
this pull request
Sep 26, 2012
Fixed JsonDeserializer for new Date format (two unit tests were broken).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.