fix(jobs): local runner for enterprise #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
changed the title
TBonnin
approved these changes
May 28, 2024
TBonnin
reviewed
May 28, 2024
| @@ -29,7 +29,7 @@ export function getRunnerId(suffix: string): string { | |||
|
|
|||
| export async function getOrStartRunner(runnerId: string): Promise<Runner> { | |||
| const waitForRunner = async function (runner: Runner): Promise<void> { | |||
| const timeoutMs = 5000; | |||
| const timeoutMs = isEnterprise ? 60000 : 5000; | |||
There was a problem hiding this comment.
not sure this is necessary since for remote runner we can assume it is always on (ie: it is not managed by nango)
bodinsamuel
reviewed
May 28, 2024
https://nangohq.slack.com/archives/C067NRBH1LL/p1716911965222909 |
bodinsamuel
approved these changes
May 28, 2024
Fair, description updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issues with the runner failing health checks for enterprise. Using a a remote runner requires the API call from jobs to the runner stay open for the duration of the sync. This can be problematic as the connection can drop or be terminated for a number of reasons. This piece of [code](https://github.com/NangoHQ/nango/blob/master/packages/jobs/lib/integration.service.ts#L124-L133] should be refactored soon so that this logic is more portable across different cloud providers besides just our own.
Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)