fix(connection): upsert return full connection, logs #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
May 29, 2024
| @@ -124,7 +130,7 @@ class ConnectionService { | |||
| accountId: number | |||
| ): Promise<ConnectionUpsertResponse[]> { | |||
| const storedConnection = await this.checkIfConnectionExists(connectionId, providerConfigKey, environment_id); | |||
| const config_id = await configService.getIdByProviderConfigKey(environment_id, providerConfigKey); | |||
| const config_id = await configService.getIdByProviderConfigKey(environment_id, providerConfigKey); // TODO remove that | |||
There was a problem hiding this comment.
why does it need to be removed?
There was a problem hiding this comment.
we are already fetching the config earlier in most cases
khaliqgant
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes NAN-1041
Upserting connection now returns full row
Some part of the code still query connection again after that, ideally we would reuse the object but I tried to limit the number of changes
Add missing context for logs where needed