Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

(Obsolete) Firefox build discussion thread #41

Closed
jspenguin2017 opened this issue Dec 15, 2017 · 256 comments
Closed

(Obsolete) Firefox build discussion thread #41

jspenguin2017 opened this issue Dec 15, 2017 · 256 comments
Labels
archived This thread was archived, open new issues for similar problems. META

Comments

@jspenguin2017
Copy link
Member

jspenguin2017 commented Dec 15, 2017

Warning: Someone submitted an unofficial build of the extension to the store, make sure to download the real one here: https://addons.mozilla.org/en-US/firefox/addon/real-nano-adblocker/

@Niftator
Copy link

The "get it for firefox" link at https://github.com/NanoAdblocker/NanoCore links here instead of, you know, anywhere useful, like an actual download link or anything.

@reunicorn
Copy link

@Niftator The extension is not yet available for download on Firefox. Right now it's only available for Chrome.

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Dec 18, 2017

@Niftator I wrote "Work in progress", which means it's not done and ready yet.
This issue is for developers who wants to comment on it, like what needs to be changed to make it work on Firefox.

@jspenguin2017
Copy link
Member Author

@Niftator It is up in the store now, I think I packaged the right files.
https://addons.mozilla.org/en-US/firefox/addon/real-nano-adblocker/

@jspenguin2017 jspenguin2017 changed the title Nano Adblocker for Firefox issues mega thread Nano Adblocker / Defender for Firefox issues mega thread Dec 23, 2017
@nanisise
Copy link

Is it possible for supporting firefox 56?

@xlollomanx
Copy link

@nanisise I read somewhere jspenguin will not support ff56 because it need a different language to build extension and it's going to die.

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Dec 24, 2017

For ND, no, because I absolutely need the new API in FF 57. And support for FF 57 may drop as soon as FF 58 is out because of browser bugs. Anti-adblock solutions are bleeding edge, you need to be on the latest technology to defeat sophisticated anti-adblock scripts.
Nano Adblocker supports back to FF 52 like uBO.

For legacy platforms, Nano Adblocker might support it if requested, but the support will drop as soon as it's dropped in uBO. However, chances are you'll be better to stay with uBO on legacy platforms as I have 0 experience coding legacy extensions.

@TonyTough
Copy link

TonyTough commented Dec 25, 2017

Just a cosmetic issue:
If using Nano Defender with Ublock Origin in Firefox, the additional filter lists Nano Base, Nano Timer and Nano Whitelist are shown as URL under addtional filters in Ublock Origin
whereas Nano Defender Integration List is shown correctly as list name.

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Dec 25, 2017

That feels like a bug in uBO where the title information isn't passed back. Nano has the problem as well, but in Nano's case, the title is hard coded into assets.json.

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Dec 25, 2017

I can only debug one add-on at a time in Firefox?

@88b88power
Copy link

Are there any websites where we can test whether the Nano Defender is working?

@jspenguin2017
Copy link
Member Author

@Chrisnetika
Copy link

Chrisnetika commented Dec 28, 2017

Hi guys, I'm a new user though before I have been using UBlock.I have a question, I want to mod the popup thingie idk what it's call where you can disable ad blocker and has buttons where you can zap element.What I want to do is add a button where I can enable/disable my filters on the fly.Reason why? Well I only have one custom filter and it's for https://*-edge-chat.facebook.com and what that does is hide last active on facebook as well semi disables fb chat.What I basically want to do is toggle that on the fly.I figure bit coding hack that toggles my filters setting fast.Is this possible? I understand every update will revert this and I would have to manually edit it back in every time.

@elypter
Copy link

elypter commented Dec 28, 2017

why not create a userscript?

@jspenguin2017
Copy link
Member Author

@Chrisnetika You would need to fork, Chrome will enforce code integrity of extensions and once signed, it won't load if changed.

@Chrisnetika
Copy link

Chrisnetika commented Dec 28, 2017

Or I could repackage it while in developer mode, then whitelist the extension ID using group policy templates problem solved.I was looking around files and pinpointed the file I would probaly need to edit is js/popup.js.There already 4 buttons in tools at the bottom ie: toggle remote font,disable cosmetic filtering.. etc so i'm thinking can add one for my filters toggle.Only thing is... not sure what I need to add unless I spend hours looking through source and do trial and error lol. But yes I would need to fork ,do my edits and any updates I can just pull and preserve my edits, package the extension then add the extension i.d to whitelist via group policy (gets rid of annoying msgs in chrome)

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Dec 28, 2017

@Chrisnetika You need to send a message to the background page, then:

  • Remove / add your filter from / to nano.selectedFilterLists
  • Call nano.loadFilterLists

You should check to make sure nano.selectedFilterListsLoaded is true and nano.loadingFilterLists is false to prevent savedata corruption.

I didn't test it, hopefully it works.

@Chrisnetika
Copy link

alright that a step in the right direction, thank you

@jspenguin2017 jspenguin2017 modified the milestones: Future, v1.0.1 Jan 1, 2018
@necros2k7
Copy link

Hi there. 1. Is it possible to use Nano defender with Umatrix, Ublock?
2. Can someone give cons & pros for using Nano blocker not other blockers?

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Jan 5, 2018

  1. Yes. See: https://jspenguin2017.github.io/uBlockProtector/ Although uAssets should be able to neutralize anti-adblock scripts of a good amount of websites.
  2. uBO is more stable and can be slightly faster, Nano goes for bleeding edge and have more features, but in turn is less stable and slightly slower. The performance hit for loading Nano's resources into uBO is untested, Nano will for sure cache its extra resources efficiently. uBO is recommended if you want something that is "install and forget", Nano is recommended if you need Nano Defender or use dashboard (write custom filters, etc) a lot.

@KudoAmine
Copy link

Works great on Firefox Quantum! Thanks.

@bobsage123
Copy link

Apologies, not a developer but have a question. If we use this for firefox and ublock, should we totally get rid of AAK-Cont? Or can they work in conjunction?

@krystian3w
Copy link

krystian3w commented Mar 30, 2018

Keep us updated on what you are doing please. I want to ensure we all get the updates.

Really?

How I create self-signed Nano Defender: (click to read)
  1. Download latest uBlock Protector repository
  2. Edit file manifest.json to add verification minimum Firefox version and remove line minimal support chrome version
  3. When I installed node.js and webxt program (to singing addon from console) run .bat"
    • I run Update Compile.bat > uBO-Extra.bat > Disable Debug Mode.bat (Maybe unnecessary / dangerous)
    • I run my webxt-sign.bat:
      web-ext sign --api-key=user:XXXXXXXXXXX --api-secret=XXXXXXXX --id={XXXXXXXXX} --source-dir=Extension --artifacts-dir=Signed
      
  4. after a while time, I have self-signed an add-on in Signed catalog

Can you guys start a collaboration in a real repository? This thread is getting unusable.
Check what gorhill did to get auto-update working.

https://github.com/NanoAdblocker/NanoDefender/issues/33 maybe waiting for vrackfall 😄

I hosted it on my dropbox but maybe we can find a better host for future, anyone have any idea?

Maybe github/gitlab page ➕ github/gitlab releases.

@Corruptinglyneedful
Copy link

OK very lost.

@krystian3w
Copy link

https://github.com/krystian3w/NanoDefenderFirefox/releases

Still I cannot merge only changes and automatic this process + create automatic self-signed version.

Maybe latter open issues.

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Apr 7, 2018

@krystian3w Check what gorhill did to make his self-hosted version auto-update.

@Cs1cs0
Copy link

Cs1cs0 commented Apr 13, 2018

https://www.techradar.com beat it the Nano Adblocker +Nano Defender combo (windows 10 Firefox x64 59.0.2)

@jspenguin2017
Copy link
Member Author

@Cs1cs0 Works fine for me.

@DiaoulDu
Copy link

Sounds strange, a month ago I've reported a problem with 1fichier.com looping for me when Nano and co are enabled and Hugo said like in this case (works fine for me). So I guess it's a problem on a filtering list side. Well, my looping problem is still alive, currently I only use Chrome when 1fichier.com is requested !

@krystian3w
Copy link

krystian3w commented Apr 13, 2018

Report in new issue if can reproduce (your configuration uBO/Nano Adblocker + step by step) in Chrome.


I can send file to 1ficher.com (no loops, maybe bug in forms see file name and no working buttons delete file - in filter subscribed list for uBO/Nano Adblocker) an no have adblock alert on techradar.com

1fichier.com##script:inject(nowebrtc.js)
||1fichier.com^$csp=script-src 'self' 'unsafe-inline' data:

if this rules is gulity on 1ficher.com (break website functions), should by reported to uAssets.

@aasril
Copy link

aasril commented Apr 14, 2018

I also have the same problem with techradar. they detected adblocker (in my case uBO + Nano Defender) and redirect to this page https://www.techradar.com/cc.html. I'm on LinuxMint with Firefox 60.0b11.

@aasril
Copy link

aasril commented Apr 14, 2018

@krystian3w I reinstalled Nano Defender with release from your page (v. 13.57). Followed all extra steps from https://jspenguin2017.github.io/uBlockProtector/. It resulted 3 extra filters on uBlockOrigin filters list: NanoBase, NanoDefender, and NanoWhitelist. Is that what final result should be like?. I also have added https://jspenguin.com/NanoAdblocker/AssetsMirror/NanoResources.txt to userResourcesLocation.

The reason I ask is because previously I have another filter named Nano Defender Integration in custom filter segment of UBO which I had removed prior to reinstall.

@Corruptinglyneedful
Copy link

Because Nano Defender no longer works with Firefox and they don't care to fix it. They discontinued the project and care to neither support version 56 and beyond.

It is ultimately disappointing to say the least.

I refuse to upgrade Firefox until TMP supports the new web extension API.

@Corruptinglyneedful
Copy link

Only wants to support memory hog chrome which scarified user options and customization for security rather than work with Mozilla and get the problem sorted out.

@jspenguin2017
Copy link
Member Author

My tablet has 4 GB RAM and Chrome works fine, I never had memory issues.
I don't know how to work with Mozilla, replacing innerHTML is out of question.

@krystian3w
Copy link

krystian3w commented Apr 14, 2018

@aasril I can read articles techradar.com, see "Recommended videos for you..." and no have redirect.
(Firefox 59.0.2 x86, Windows 10 Pro x86)

Maybe bug with specific list (non-default / regional list) or exclusion GNU/Linux (try override user-agent to Windows).

@aasril
Copy link

aasril commented Apr 14, 2018

@krystian3w changing user agent to any desktop browsers doesn't work but changing it to mobile works (Android-Chrome).

@vincetran96
Copy link

@aasril Don't know if you tried blocking inline scripts yet. That method got rid of that redirection for me, but the majority of images on that website also were blocked.

@aasril
Copy link

aasril commented Apr 18, 2018

@vietzerg what rule are you using for blocking the inline scripts. I don't visit that website personally just tested when I read from the post above.

I don't know if this is related but from console window on block page I find this 3-content-rules-1-common.js. And under const genericWhitelist1 there is this line
//False positives
"techradar.com", "imdb.com", "babbel.com", "buxfer.com", "store.playstation.com", "lemonde.fr",
"derstandard.at",

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Apr 18, 2018

It is whitelisted in Nano Defender, and it is intentional.

@mzso
Copy link

mzso commented Apr 20, 2018

@FaySmash commented on 2018. márc. 27. 07:27 CEST:

(though firefox support will be dropped in the future).

Any particular reason why the FF version is being dropped?

@jspenguin2017
Copy link
Member Author

jspenguin2017 commented Apr 20, 2018

@mzso Currently, the UserCSS code is conflicting with Chrome version. There will be more conflicts like this if I want to keep the Firefox build, and I don't feel like dealing with it.

For official builds, I want Nano to be equally as good as uBO if not better. Since I don't use Firefox, I barely test on it, and it is irresponsible to publish untested softwares, so I decided to drop it all together.

I don't use Edge neither, but I made the Edge build since the official uBO for Edge is not that functional. It may or may not stay in the long term.

@vincetran96
Copy link

@vietzerg what rule are you using for blocking the inline scripts. I don't visit that website personally just tested when I read from the post above.

@aasril I used the "local block" (red color) rule for techradar.com.

@elypter
Copy link

elypter commented Apr 23, 2018

could you at least keep the old version? i wanted to try out something with a new profile and was searching like crazy because it was still there a few days ago.

@NanoAdblocker NanoAdblocker locked and limited conversation to collaborators Apr 23, 2018
@jspenguin2017 jspenguin2017 changed the title Nano Adblocker / Defender for Firefox issues mega thread (Old) Firefox build discussion thread Apr 23, 2018
@jspenguin2017
Copy link
Member Author

The support for Firefox has officially ended. No more Firefox build will be produced.

@jspenguin2017
Copy link
Member Author

@elypter Probably not, the latest version has a regression on Firefox.

@jspenguin2017 jspenguin2017 changed the title (Old) Firefox build discussion thread (Obsolete) Firefox build discussion thread Apr 23, 2018
@jspenguin2017 jspenguin2017 removed this from the v1.0.1 milestone Apr 23, 2018
@jspenguin2017 jspenguin2017 added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This thread was archived, open new issues for similar problems. META
Projects
None yet
Development

No branches or pull requests