Permalink
Browse files

LordFocas added to the travis builds

  • Loading branch information...
ritchieGitHub committed Aug 25, 2016
1 parent 02ace10 commit 3d31497e70fac4abd94d22332a9738a8e02f6963
Showing with 1 addition and 0 deletions.
  1. +1 −0 .travis.yml
View
@@ -22,6 +22,7 @@ notifications:
email:
- richard.vannieuwenhoven@adesso.at
- elonen@iki.fi
- diogo.duarte@techie.com
env:
global:

5 comments on commit 3d31497

@LordFokas

This comment has been minimized.

Show comment
Hide comment
@LordFokas

LordFokas Aug 25, 2016

Member

I had that one on my PR :|

Member

LordFokas replied Aug 25, 2016

I had that one on my PR :|

@ritchieGitHub

This comment has been minimized.

Show comment
Hide comment
@ritchieGitHub

ritchieGitHub Aug 26, 2016

Member

sorry, was waiting so long to add you. ;-)) I had to do it the first second I knew what to write.... Great that you started the 3.0 work!

Member

ritchieGitHub replied Aug 26, 2016

sorry, was waiting so long to add you. ;-)) I had to do it the first second I knew what to write.... Great that you started the 3.0 work!

@LordFokas

This comment has been minimized.

Show comment
Hide comment
@LordFokas

LordFokas Aug 26, 2016

Member

I'll have more coming as soon as the current PR is accepted.
I've split the protocol server classes into logical units, and I'll start a new PR with the more breaking changes once that is accepted. Also notice how I've split the original 3.0.0 issue into 4 tasks since that is way too big to count only as one ( see #278 )

Member

LordFokas replied Aug 26, 2016

I'll have more coming as soon as the current PR is accepted.
I've split the protocol server classes into logical units, and I'll start a new PR with the more breaking changes once that is accepted. Also notice how I've split the original 3.0.0 issue into 4 tasks since that is way too big to count only as one ( see #278 )

@ritchieGitHub

This comment has been minimized.

Show comment
Hide comment
@ritchieGitHub

ritchieGitHub Aug 26, 2016

Member

@LordFokas looks very good to me ;-) and you are in control you can merge the PR whenever you want. (But Repair the tests before..)
proposal: when you are making a breaking change, maybe also rename the packages to org.nanohttpd.abc.def...??

Member

ritchieGitHub replied Aug 26, 2016

@LordFokas looks very good to me ;-) and you are in control you can merge the PR whenever you want. (But Repair the tests before..)
proposal: when you are making a breaking change, maybe also rename the packages to org.nanohttpd.abc.def...??

@LordFokas

This comment has been minimized.

Show comment
Hide comment
@LordFokas

LordFokas Aug 26, 2016

Member

But I did that. To every package. And restructured the protocol packages to org.nanohttpd.protocols.

I have no idea what's wrong with the tests, they're just like they were when I pulled master into my machine, I didn't mess with the test code (yet).

And I know I'm in control, but I feel 3.0 is too big for me to push it all into master by myself without feedback.

Member

LordFokas replied Aug 26, 2016

But I did that. To every package. And restructured the protocol packages to org.nanohttpd.protocols.

I have no idea what's wrong with the tests, they're just like they were when I pulled master into my machine, I didn't mess with the test code (yet).

And I know I'm in control, but I feel 3.0 is too big for me to push it all into master by myself without feedback.

Please sign in to comment.