Skip to content

Commit

Permalink
LordFocas added to the travis builds
Browse files Browse the repository at this point in the history
  • Loading branch information
@ritchieGitHub
ritchieGitHub committed Aug 25, 2016
1 parent 02ace10 commit 3d31497
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ notifications:
email:
- richard.vannieuwenhoven@adesso.at
- elonen@iki.fi
- diogo.duarte@techie.com

env:
global:
Expand Down

5 comments on commit 3d31497

@LordFokas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that one on my PR :|

@ritchieGitHub
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, was waiting so long to add you. ;-)) I had to do it the first second I knew what to write.... Great that you started the 3.0 work!

@LordFokas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have more coming as soon as the current PR is accepted.
I've split the protocol server classes into logical units, and I'll start a new PR with the more breaking changes once that is accepted. Also notice how I've split the original 3.0.0 issue into 4 tasks since that is way too big to count only as one ( see #278 )

@ritchieGitHub
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LordFokas looks very good to me ;-) and you are in control you can merge the PR whenever you want. (But Repair the tests before..)
proposal: when you are making a breaking change, maybe also rename the packages to org.nanohttpd.abc.def...??

@LordFokas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I did that. To every package. And restructured the protocol packages to org.nanohttpd.protocols.

I have no idea what's wrong with the tests, they're just like they were when I pulled master into my machine, I didn't mess with the test code (yet).

And I know I'm in control, but I feel 3.0 is too big for me to push it all into master by myself without feedback.

Please sign in to comment.