Enhanced through calibration #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shebang and make nanovna-saver.py executable
- setup.cfg should now work flowlessly with fedoro 36 (#456) - github actions are updated to use more current software versions
…tage sweep is not always guaranteed to be an int
fix for issue #458
self.sweep_control.progress_bar.setValue() needs an int value, percen…
PA0JOZ Enhanced Response Correction
The comparison operators (<, >, etc.) are not translated 1:1 to
customisation methods (__lt__, __gt__, ...) in Python. Instead the
type of the operands plays a role in determining on which of the two
sides the customisation method is invoked (see Python Language
Reference section 3.3.1 [1]). This means 'a > b' can end up invoking
b.__lt__(a) rather than a.__gt__(b).
This behaviour can causes infinite recursion in Version.__lt__():
2022-03-07 13:47:52,087 - NanoVNASaver.Hardware.NanoVNA_V2 - ERROR - Timeout reading version registers
Traceback (most recent call last):
File "/home/sascha/nanovna-saver/NanoVNASaver/Controls/SerialControl.py", line 73, in serialButtonClick
self.connect_device()
File "/home/sascha/nanovna-saver/NanoVNASaver/Controls/SerialControl.py", line 93, in connect_device
self.app.vna = get_VNA(self.interface)
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/Hardware.py", line 101, in get_VNA
return NAME2DEVICE[iface.comment](iface)
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/NanoVNA_V2.py", line 76, in __init__
super().__init__(iface)
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/VNA.py", line 71, in __init__
self.read_features()
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/NanoVNA_V2.py", line 107, in read_features
if self.board_revision >= Version("2.0.4"):
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 63, in __le__
return self < other or self == other
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 57, in __lt__
return other > self
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 57, in __lt__
return other > self
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 57, in __lt__
return other > self
[Previous line repeated 491 more times]
RecursionError: maximum recursion depth exceeded in comparison
Fix it by explicitly invoking the customisation methods we expect.
[1] https://docs.python.org/3/reference/datamodel.html#object.__lt__
Version: avoid infinite recursion
Add additional indentation to force code formatting of command lines. (Could use triple-backticks instead.)
Fix command-line formatting in README.md
github workflow fixes
Allow 2 digit versions. Fixes #483
|
0.4.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.