Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devise gem #11

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Add devise gem #11

merged 5 commits into from
Aug 30, 2023

Conversation

Nasirkhan294
Copy link
Owner

@Nasirkhan294 Nasirkhan294 commented Aug 30, 2023

Project requirements

  • Remove the current_user method in ApplicationController, devise will provide us with one.

  • Install and set up devise.

    • Can register a new user.
    • User logs in with a combination of email and password.
    • A hashed password should be stored in the database.
    • Ask for confirmation of email.
    • Can reset password.

Modify the views in devise for registration and login to match the wireframes from the Sneak Peek and your styling.

Copy link

@ichala ichala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Student ,

Status: Approved ✔️ ✔️ ✔️

68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f6c3366516333614356304871707a5763552f67697068792e676966

To Highlight 💪🏻

  • A user can log in with a combination of email and password✔️
  • The application allows for registering a new user✔️
  • A hashed password is stored in the database✔️
  • The current_user method in ApplicationController has been removed✔️

Good job implementing the requirements 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional Suggestions :

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag ichala in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Nasirkhan294 Nasirkhan294 merged commit 100d848 into dev Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants