Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make NN ensemble suggest operations silent #620

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

osma
Copy link
Member

@osma osma commented Sep 5, 2022

This one-line PR makes NN ensemble suggest operations silent. They used to be quiet at least in Annif 0.57, but apparently something changed in TensorFlow and now there are messages like this:

1/1 [==============================] - 0s 15ms/step 
1/1 [==============================] - 0s 15ms/step 
1/1 [==============================] - 0s 15ms/step

@osma osma added the bug label Sep 5, 2022
@osma osma added this to the 0.59 milestone Sep 5, 2022
@osma osma self-assigned this Sep 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #620 (e0ca692) into master (48b23f7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          87       87           
  Lines        6034     6038    +4     
=======================================
+ Hits         6011     6015    +4     
  Misses         23       23           
Impacted Files Coverage Δ
annif/backend/nn_ensemble.py 99.29% <ø> (ø)
tests/test_vocab.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@osma osma merged commit b655627 into master Sep 5, 2022
@osma osma deleted the fix-nn-ensemble-verbosity branch September 5, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant