Avoid sending empty email when invoking the feedback form. #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
============================================
+ Coverage 67.96% 67.97% +0.01%
Complexity 1584 1584
============================================
Files 32 32
Lines 3889 3888 -1
============================================
Hits 2643 2643
+ Misses 1246 1245 -1
Continue to review full report at Codecov.
|
miguelvaara
approved these changes
Apr 7, 2021
|
Relevant code changes 👍 |
|
Changes tested and everything works well 👍 🥇 |
miguelvaara
moved this from Issue/PR closed
to Done (verified in dev.finto.fi and documented in wiki and RN)
in Sprint Backlog I/2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a logic error in WebController. The feedback message is always sent even when just displaying the feedback form. This was previously hidden by the honeypot check, but the bug surfaced after the changes to honeypot code in PR #1131.
Fixes #1139