Show newly deprecated #1165
Show newly deprecated #1165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
============================================
+ Coverage 68.36% 68.85% +0.49%
- Complexity 1619 1627 +8
============================================
Files 32 32
Lines 3973 3994 +21
============================================
+ Hits 2716 2750 +34
+ Misses 1257 1244 -13
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed.
|
|
For this to work as intended, finto.css needs to be modified by removing line 480 for .nav-tabs > li.active > a : |
MikkoAleksanteri
added this to Proposed product backlog items
in Sprint Backlog III/2021
kouralex
moved this from Proposed product backlog items
to Selected product backlog items
in Sprint Backlog III/2021
joelit
moved this from Selected product backlog items
to In progress
in Sprint Backlog III/2021
model/sparql/GenericSparql.php
Outdated
| WHERE { | ||
| ?concept a skos:Concept ; | ||
| skos:prefLabel ?label . | ||
| FILTER (langMatches(lang(?label), '$lang')) |
There was a problem hiding this comment.
Even though it was already like this, this will filter out all concepts without a content language label, thus, resulting in incomplete listing. If one wants to fix it, one must use the fallback method found elsewhere in this file.
There was a problem hiding this comment.
Side note: in theory, this affects also replacedByLabel.
|
SonarCloud Quality Gate failed.
|
…he first column of the line.
joelit
force-pushed
the
show-newly-deprecated
branch
from
ef322aa
to
e7f3bef
Compare
joelit
moved this from Selected product backlog items
to Needs review
in Sprint Backlog IV/2021
|
SonarCloud Quality Gate failed.
|
joelit
moved this from Issue/PR closed
to Done (verified in dev.finto.fi and documented in wiki and RN)
in Sprint Backlog IV/2021
This is an otherwise ready PR - however, the labels for new concepts replacing deprecated ones is not implemented since it caused a significant regression in performance. A follow-up fix will come later.