Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML generation styling hack, Re-implement via CSS. #110

Closed
NathanGibbs3 opened this issue Jul 18, 2021 · 1 comment
Closed

HTML generation styling hack, Re-implement via CSS. #110

NathanGibbs3 opened this issue Jul 18, 2021 · 1 comment
Assignees
@NathanGibbs3
Labels
enhancement New feature or request invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. UI User Interface Issues.
Projects
Style Data Migration.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented Jul 18, 2021 •
edited

Item Description
File: includes/base_output_html.inc.php base_maintenance.php
Class: N/A
Function: PrintFramedBoxHeader()
Similar Issues: #19 #25 #105 #114
Depends on Issue(s): N/A
Dependency Type: N/A
Misc. Info.: N/A

Expected Behavior:
Same or similar visual results implemented via CSS.
Current Behavior:
The code produces an HTML styling hack, a nested table that visually appears as a single table with a colored border 2px wide.
@NathanGibbs3 NathanGibbs3 added enhancement New feature or request invalid This doesn't seem right Prod Observed in Production Environment. LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. UI User Interface Issues. labels Jul 18, 2021
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Jul 18, 2021
@NathanGibbs3 NathanGibbs3 self-assigned this Jul 18, 2021
This was referenced Jul 18, 2021
Closed
Closed
Closed
@NathanGibbs3 NathanGibbs3 added this to Needs triage in Style Data Migration. via automation Jul 20, 2021
@NathanGibbs3 NathanGibbs3 moved this from Needs triage to High priority in Style Data Migration. Jul 20, 2021
@NathanGibbs3 NathanGibbs3 mentioned this issue Nov 16, 2021
Closed
Style Data Migration. automation moved this from High priority to Closed Nov 30, 2021
@NathanGibbs3
Copy link
Owner Author

Found the same issue in base_maintenance.php. Will repair with calls to PrintFramedBoxHeader() & PrintFramedBoxFooterer().

@NathanGibbs3 NathanGibbs3 reopened this Jan 29, 2023
Style Data Migration. automation moved this from Closed to High priority Jan 29, 2023
Style Data Migration. automation moved this from High priority to Closed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
enhancement New feature or request invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. UI User Interface Issues.
Projects
Style Data Migration.
  
Closed
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3