Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Criteria HTML styling hack, Re-implement via CSS. #25

Closed
NathanGibbs3 opened this issue May 9, 2019 · 0 comments
Closed

Search Criteria HTML styling hack, Re-implement via CSS. #25

NathanGibbs3 opened this issue May 9, 2019 · 0 comments
Assignees
@NathanGibbs3
Labels
enhancement New feature or request invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. UI User Interface Issues.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented May 9, 2019 •
edited
Loading

Item Description
File: base_qry_common.php
Class: N/A
Function: PrintCriteria()
Similar Issues: #19 #105 #110 #114
Depends on Issue(s): N/A
Dependency Type: N/A
Misc. Info.: CGI Action: list

Expected Behavior:
Same or similar visual results implemented via CSS.
Current Behavior:
Like #19 , the code produces an HTML styling hack, a nested table that visually appears as a single table with a black border 2px wide.
Inside this, the code produces a similar hack, a table with a grey bgcolor="#DDDDDD" border 1px wide.
The search criteria table appears as if in a single frame with a black border and grey cell padding.
👍 for visual creativity. 👎 for code clarity & maintainability. ☹️
@NathanGibbs3 NathanGibbs3 added enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right Prod Observed in Production Environment. LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. labels May 9, 2019
@NathanGibbs3 NathanGibbs3 mentioned this issue May 9, 2019
Closed
@NathanGibbs3 NathanGibbs3 changed the title Styling hack similar to #19 , Re-implement via CSS. Search Criteria HTML Styling hack , Re-implement via CSS. May 9, 2019
@NathanGibbs3 NathanGibbs3 changed the title Search Criteria HTML Styling hack , Re-implement via CSS. Search Criteria HTML styling hack , Re-implement via CSS. May 9, 2019
@NathanGibbs3 NathanGibbs3 changed the title Search Criteria HTML styling hack , Re-implement via CSS. Search Criteria HTML styling hack, Re-implement via CSS. May 9, 2019
@NathanGibbs3 NathanGibbs3 added the UI User Interface Issues. label May 15, 2020
@NathanGibbs3 NathanGibbs3 mentioned this issue Jul 16, 2021
Closed
@NathanGibbs3 NathanGibbs3 self-assigned this Jul 16, 2021
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Jul 16, 2021
@NathanGibbs3 NathanGibbs3 mentioned this issue Jul 18, 2021
Closed
@NathanGibbs3 NathanGibbs3 removed the good first issue Good for newcomers label Jul 20, 2021
@NathanGibbs3 NathanGibbs3 mentioned this issue Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
enhancement New feature or request invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. UI User Interface Issues.
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3