Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8x - Deprecated: Use of each. #153

Closed
NathanGibbs3 opened this issue Mar 24, 2023 · 0 comments
Closed

PHP 8x - Deprecated: Use of each. #153

NathanGibbs3 opened this issue Mar 24, 2023 · 0 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working DB Database Issues invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. PHP 8x Issues affecting PHP 8x compatibility Tests Test Code & Config Issues. Local or CI Environments.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented Mar 24, 2023 •
edited
Loading

Item Description
File(s): base_qry_common.php includes/base_output_query.inc.php base_graph_common.php base_local_rules.php includes/base_state_query.inc.php:
Class: N/A
Function: DateTimeRows2sql() GetSortSQL() PrintHeader() GeoIPfree_IP2Country() GetCountryDataSet() pcre_grep_file_poor() GetNumResultRows() PrintAlertActionButtons()
Similar Issues:
Depends on Issue(s):
Dependency Type:
Misc. Info.:

Expected Behavior: Re implement functionality using foreach
Current Behavior: Use of deprecated PHP keyword each
@NathanGibbs3 NathanGibbs3 added bug Something isn't working invalid This doesn't seem right Tests Test Code & Config Issues. Local or CI Environments. Prod Observed in Production Environment. LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. DB Database Issues labels Mar 24, 2023
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Mar 24, 2023
@NathanGibbs3 NathanGibbs3 self-assigned this Mar 24, 2023
@NathanGibbs3 NathanGibbs3 removed the Prod Observed in Production Environment. label Mar 24, 2023
NathanGibbs3 added a commit that referenced this issue Mar 26, 2023
@NathanGibbs3
20230326 Fix CI build breakage.
ae886da 
         Related Issue(s) #151 #153 #154 #155
@NathanGibbs3 NathanGibbs3 changed the title DateTimeRows2sql() breaks PHP 8.x compatibility. Use of each breaks PHP 8.x compatibility. Mar 26, 2023
NathanGibbs3 added a commit that referenced this issue Mar 28, 2023
@NathanGibbs3
20230327 Fix CI build breakage.
6719aba 
         Related Issue(s) #153 #154 #155 #157
@NathanGibbs3 NathanGibbs3 changed the title Use of each breaks PHP 8.x compatibility. PHP 8.x - Use of each breaks builds Mar 28, 2023
@NathanGibbs3 NathanGibbs3 changed the title PHP 8.x - Use of each breaks builds PHP 8x - Use of each breaks builds Apr 5, 2023
@NathanGibbs3 NathanGibbs3 added the PHP 8x Issues affecting PHP 8x compatibility label Apr 6, 2023
@NathanGibbs3 NathanGibbs3 changed the title PHP 8x - Use of each breaks builds PHP 8x - Deprecated: Use of each. Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working DB Database Issues invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. PHP 8x Issues affecting PHP 8x compatibility Tests Test Code & Config Issues. Local or CI Environments.
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3