Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.1+ - CleanVariable() invalid data mask crash #157

Closed
NathanGibbs3 opened this issue Mar 26, 2023 · 0 comments
Closed

PHP 7.1+ - CleanVariable() invalid data mask crash #157

NathanGibbs3 opened this issue Mar 26, 2023 · 0 comments
Assignees
@NathanGibbs3
Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

Item Description
File(s): includes/base_state_common.inc.php
Class:
Function: CleanVariable()
Similar Issues:
Depends on Issue(s):
Dependency Type:
Misc. Info.: https://www.php.net/manual/en/migration71.other-changes.php New E_WARNING and E_NOTICE errors have been introduced when invalid strings are coerced using operators expecting numbers (+ - * / ** % << >>

Expected Behavior: Function runs.
Current Behavior: Function crashes on PHP 7.1+
@NathanGibbs3 NathanGibbs3 added bug Something isn't working invalid This doesn't seem right Prod Observed in Production Environment. LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Stability Issue impacts or is related to App Stability. labels Mar 26, 2023
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Mar 26, 2023
@NathanGibbs3 NathanGibbs3 self-assigned this Mar 26, 2023
NathanGibbs3 added a commit that referenced this issue Mar 28, 2023
@NathanGibbs3
20230327 Fix CI build breakage.
6719aba 
         Related Issue(s) #153 #154 #155 #157
@NathanGibbs3 NathanGibbs3 changed the title CleanVariable() invalid data mask crashes on PHP 7.1+ PHP 7.1+ - CleanVariable() invalid data mask crash Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
bug Something isn't working invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3