Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerifyDBAbstractionLib() Not operative under safe mode. #34

Closed
NathanGibbs3 opened this issue May 30, 2019 · 3 comments
Closed

VerifyDBAbstractionLib() Not operative under safe mode. #34

NathanGibbs3 opened this issue May 30, 2019 · 3 comments
Assignees
@NathanGibbs3
Labels
DB Database Issues invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Milestone
1.4.6

Comments

@NathanGibbs3
Copy link
Owner

NathanGibbs3 commented May 30, 2019 •
edited

Item Description
File: includes/base_db.inc.php
Class: N/A
Function: VerifyDBAbstractionLib()
Similar Issues:
Related Issues: https://sourceforge.net/p/secureideas/bugs/47
Depends on Issue(s):
Dependency Type: N/A
Misc. Info.: The safe mode cutout was added on 20050325. It may only be needed on PHP Versions below 5.1.5 as PHP 5.1x was released on 20051124. See https://www.php.net/manual/en/function.is-readable.php Will need to research this further.

Expected Behavior: VerifyDBAbstractionLib() is operative under safe mode where possible.
Current Behavior: VerifyDBAbstractionLib() function is not operative under safe mode.
@NathanGibbs3 NathanGibbs3 added invalid This doesn't seem right question Further information is requested Prod Observed in Production Environment. LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. labels May 30, 2019
@NathanGibbs3
Copy link
Owner Author

NathanGibbs3 commented May 31, 2019 •
edited

Research Results: PHP Safe Mode History.
Safe Mode has been around since before Version 4.0, Beta 4
See: https://www.php.net/ChangeLog-4.php
Was deprecated in PHP 5.3x and removed in PHP 5.4x.
See: https://www.php.net/manual/en/features.safe-mode.php

@NathanGibbs3 NathanGibbs3 removed the question Further information is requested label May 31, 2019
NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Fix Attempt 1
34f7f22
NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Fix Attempt 2
bb1f3eb
NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Fix Attempt 3
6aa1b23
NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Fix Attempt 4
e423b74
NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Fix Attempt 5
0edd341
NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Fix Attempt 6
90ca15d
NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Fix Attempt 7
c0fa489
@NathanGibbs3
Copy link
Owner Author

NathanGibbs3 commented May 31, 2019 •
edited

Verified: Works with PHP Safe Mode enabled on PHP 5.3.29 via CI & Unit Tests..
See: https://travis-ci.org/NathanGibbs3/BASE/jobs/539843474
See: https://travis-ci.org/NathanGibbs3/BASE/job**s/539843475
Conclusion: Should work with PHP Safe Mod enabled in PHP > 5.1.4.
See https://www.php.net/manual/en/function.is-readable.php

NathanGibbs3 added a commit that referenced this issue May 31, 2019
@NathanGibbs3
20190531 Issue #34 Build Cleanup 1
82f9dae
NathanGibbs3 added a commit that referenced this issue Jun 1, 2019
@NathanGibbs3
20190531 Issue #34 Build Cleanup 2
c5fc8d6
NathanGibbs3 added a commit that referenced this issue Jun 2, 2019
@NathanGibbs3
20190601 Issue #34 Build Cleanup 1
8f44b48
NathanGibbs3 added a commit that referenced this issue Jun 2, 2019
@NathanGibbs3
20190601 Issue #34 Build Cleanup 2
af942b9
NathanGibbs3 added a commit that referenced this issue Jun 3, 2019
@NathanGibbs3
20190602 Issue #34 Code Coverage 1
16a2bca
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190604 Closes #13 Closes #34 Closes #35
2bed94a
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 1
e51c61c 
         Cleanup Unit Test fallout from fixes for #34 & #35.
         Cleaned up code in tests/php/langtdflegacyTest.php
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 2
7b7f194 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 3
2372bb3 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 4
8eb0fbb 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 5
dbfaacc 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 6
d2f01a8 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 7
d2d4b9d 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 8
3bfb06c 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 9
9a915c0 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 10
aeaeee8 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 11
a6967f2 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 12
d6f54f5 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 5, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 13
787dad9 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 6, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 14
c37f3f9 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 6, 2019
@NathanGibbs3
20190605 Issue #11 Build fix 15
080465b 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 6, 2019
@NathanGibbs3
20190606 Issue #11 Build fix 1
c1cf3c6 
         Cleanup Unit Test fallout from fixes for #34.
@NathanGibbs3
Copy link
Owner Author

When we merged this fix into the Issue #11 branch, Unit Tests that needed process isolation started causing the builds to fail on PHP 5.3x due to safe mode deprecation errors.

NathanGibbs3 added a commit that referenced this issue Jun 6, 2019
@NathanGibbs3
20190606 Issue #11 Build fix 2
1fb20c3 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 6, 2019
@NathanGibbs3
20190606 Issue #11 Build fix 3
539d744 
         Cleanup Unit Test fallout from fixes for #34.
NathanGibbs3 added a commit that referenced this issue Jun 6, 2019
@NathanGibbs3
20190606 Issue #11 Build fix 4
5105da6 
         Reverted the Issue #34 related trainwreck on this branch.
         Back to commit: a688054
         Keep the Issue #35 corrections.
         Will fix the underlying Issue #34 problem from the
         devel branch and then remerge.
@NathanGibbs3 NathanGibbs3 mentioned this issue Jun 6, 2019
Open
NathanGibbs3 added a commit that referenced this issue Jun 6, 2019
@NathanGibbs3
20190606 Closes #34 more elegantly. Interim fix for #36.
f282322
NathanGibbs3 added a commit that referenced this issue Jun 12, 2019
@NathanGibbs3
20190612 Import Build System enhanceemnts from Issue11 branch
d452522 
         Related Issues #5, #34, #36
@NathanGibbs3 NathanGibbs3 self-assigned this Jun 26, 2019
@NathanGibbs3 NathanGibbs3 added the DB Database Issues label May 21, 2020
@NathanGibbs3 NathanGibbs3 added this to the 1.4.6 milestone Oct 8, 2020
@NathanGibbs3 NathanGibbs3 added the Stability Issue impacts or is related to App Stability. label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanGibbs3 NathanGibbs3

Labels
DB Database Issues invalid This doesn't seem right LCB-TechDebt Issue exists in Legacy Code Base. We inherited it. Prod Observed in Production Environment. Stability Issue impacts or is related to App Stability.
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
1 participant
@NathanGibbs3