Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppet Name Error Misreported #13

Closed
Eluvatar opened this issue Oct 26, 2014 · 1 comment
Closed

Puppet Name Error Misreported #13

Eluvatar opened this issue Oct 26, 2014 · 1 comment
Assignees
@Eluvatar

Comments

@Eluvatar
Copy link
Contributor

Westerly Winds reports that the puppet creator says to "please supply a style of government" if an invalid nation name is provided. (By reason of containing " - ").

The puppet creator's message should match what's actually wrong.
@Eluvatar Eluvatar self-assigned this Oct 26, 2014
Eluvatar referenced this issue Oct 26, 2014
@Afforess
Fix puppet creator (was using old addNations). Update forum settings …
48afacd 
…to work with new forum system.
Eluvatar added a commit that referenced this issue Oct 26, 2014
@Eluvatar
Fix for #13
e2092d6 
added checknationname AJAX call to check name prior to sending whole thing to
NS (NS stage 2 expects nation name to have already been checked)

corrected reference of style to government_style in nation creation, to actually
send the selected government style to NS
Afforess added a commit that referenced this issue Oct 26, 2014
@Afforess
Merge pull request #14 from Afforess/issue_13
6cc69b3 
Fix for #13
@Eluvatar
Copy link
Contributor Author

Shipped for Chrome.

@Afforess Afforess closed this as completed Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eluvatar Eluvatar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Afforess @Eluvatar