Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Collapsible - icon spinning is weird #1013

Closed
SuperITMan opened this issue Jan 8, 2019 · 0 comments · Fixed by #1226
Closed

ui: Collapsible - icon spinning is weird #1013

SuperITMan opened this issue Jan 8, 2019 · 0 comments · Fixed by #1226
Labels
comp: stark-ui type: bug
Projects
10.0.0-beta.7
Milestone
10.0.0-beta.7

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When iconSpinningEnabled is set to true, the icon has a rotation of 180° when the collapsible is expanded. The result is the icon is turned to the right when collapsed the to the left when it is expanded.

The result is not natural.

Expected behavior

When iconSpinningEnabled is set to true, the icon should have a rotation of 90° when the collapsible is expaned.
@SuperITMan SuperITMan added this to the 10.0.0-beta.2 milestone Jan 8, 2019
@SuperITMan SuperITMan added this to To do in 10.0.0-beta.2 via automation Jan 8, 2019
@SuperITMan SuperITMan changed the title ui: Collapsible - Icon spinning is weird ui: Collapsible - icon spinning is weird Jan 8, 2019
@christophercr christophercr added this to To do in 10.0.0-beta.3 via automation Jan 11, 2019
@christophercr christophercr removed this from To do in 10.0.0-beta.2 Jan 11, 2019
@christophercr christophercr removed this from To do in 10.0.0-beta.3 Feb 5, 2019
@SuperITMan SuperITMan modified the milestones: 10.0.0-beta.7, 10.0.0-rc.0 Mar 19, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 28, 2019
@carlo-nomes
fix(stark-demo): change default behaviour of collapsible icon
3a56539 
  - rotate the default icon by 90deg when the collapsible is open
  - small refactor

ISSUES CLOSED: NationalBankBelgium#1013
@carlo-nomes carlo-nomes mentioned this issue Mar 28, 2019
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 29, 2019
@carlo-nomes
fix(stark-demo): change default behaviour of collapsible icon
654dff4 
  - rotate the default icon by 90deg when the collapsible is open
  - small refactor

ISSUES CLOSED: NationalBankBelgium#1013
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Apr 1, 2019
@carlo-nomes
fix(stark-demo): change default behaviour of collapsible icon
3737371 
  - rotate the default icon by 90deg when the collapsible is open
  - small refactor

ISSUES CLOSED: NationalBankBelgium#1013
@christophercr christophercr added this to To do in 10.0.0-beta.7 via automation Apr 2, 2019
@christophercr christophercr moved this from To do to Done in 10.0.0-beta.7 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: bug
Projects
No open projects
10.0.0-beta.7
  
Done
Milestone
10.0.0-beta.7
Development

Successfully merging a pull request may close this issue.

fix(stark-demo): change default behaviour of collapsible icon carlo-nomes/stark
2 participants
@christophercr @SuperITMan