Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: table - add option to display "itemsPerPage" in the pagination of the table #1248

Closed
SuperITMan opened this issue Apr 10, 2019 · 1 comment · Fixed by #1456
Closed

ui: table - add option to display "itemsPerPage" in the pagination of the table #1248

SuperITMan opened this issue Apr 10, 2019 · 1 comment · Fixed by #1456
Assignees
@nicanac
Labels
comp: stark-ui type: feature
Projects
10.0.0-rc.3
Milestone
10.0.0-rc.3

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

There is no way for a user to change the number of items per page when he uses the table component.

Expected behavior

We should add an option to let the developer give the ability to his users to change the number of items per page.

What is the motivation / use case for changing the behavior?

Improvement
@SuperITMan SuperITMan added this to the 10.0.0-beta.8 milestone Apr 10, 2019
@SuperITMan SuperITMan modified the milestones: 10.0.0-beta.8, 10.0.0-rc.0 Apr 29, 2019
@SuperITMan SuperITMan modified the milestones: 10.0.0-rc.0, 10.1.0 May 7, 2019
@nicanac nicanac modified the milestones: 10.1.0, 10.0.0-rc.3 Nov 13, 2019
@nicanac
Copy link
Contributor

nicanac commented Nov 22, 2019

Hi @SuperITMan ,
I've a question about this issue, should we only had the drop down to select the number of items set by the developers ? Or also add an input to let the user set the exact number of items ?
Nico

nicanac added a commit to nicanac/stark that referenced this issue Nov 22, 2019
@nicanac
feat(stark-ui): add option to display items per page in the paginatio…
447fc67 
…n of table

Add an option to let the developer give the ability to his users to change the number of items per
page

ISSUES CLOSED: NationalBankBelgium#1248
@nicanac nicanac mentioned this issue Nov 22, 2019
Closed
3 tasks
@christophercr christophercr added this to To do in 10.0.0-rc.3 via automation Nov 22, 2019
@christophercr christophercr moved this from To do to In progress in 10.0.0-rc.3 Nov 22, 2019
@christophercr christophercr moved this from In progress to Review in 10.0.0-rc.3 Nov 22, 2019
@christophercr christophercr moved this from Review to In progress in 10.0.0-rc.3 Nov 22, 2019
nicanac added a commit to nicanac/stark that referenced this issue Nov 28, 2019
@nicanac
feat(stark-ui): add option to display items per page in the paginatio…
1186b46 
…n of table

Add an option to let the developer give the ability to his users to change the number of items per
page

ISSUES CLOSED: NationalBankBelgium#1248
christophercr added a commit to christophercr/stark that referenced this issue Nov 29, 2019
@christophercr
feat(stark-ui): add support for displaying the "items per page" dropd…
c8fe2f0 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
@christophercr christophercr mentioned this issue Nov 29, 2019
Merged
3 tasks
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 3, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
267103d 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 6, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
6685b58 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 6, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
187b1b4 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 6, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
f7b6805 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 7, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
0285d55 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 7, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
b5db587 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 8, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
220938a 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 8, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
8082797 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 8, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
1204563 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 8, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
4b6d805 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 8, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
09d60d0 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 8, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
97fe135 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
nicanac pushed a commit to christophercr/stark that referenced this issue Jan 8, 2020
@christophercr @nicanac
feat(stark-ui): add support for displaying the "items per page" dropd…
705bb23 
…own also in Pagination on "compact" mode

ISSUES CLOSED: NationalBankBelgium#1248
10.0.0-rc.3 automation moved this from In progress to Done Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicanac nicanac

Labels
comp: stark-ui type: feature
Projects
No open projects
10.0.0-rc.3
  
Done
Milestone
10.0.0-rc.3
2 participants
@SuperITMan @nicanac