Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: table - add a visual indicator when the global filter is enabled #1303

Closed
christophercr opened this issue May 29, 2019 · 1 comment · Fixed by #1310
Closed

ui: table - add a visual indicator when the global filter is enabled #1303

christophercr opened this issue May 29, 2019 · 1 comment · Fixed by #1310

Comments

@christophercr
Copy link
Collaborator

christophercr commented May 29, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When the global filter is enabled in the table component, there is no indicator whatsoever about such filtering, which might be confusing for the end user when the data in the table is refreshed and he might expect to see all the rows but he will only see the filtered ones.

Expected behavior

A visual indicator should be in place so the user knows that he as the global filter enabled. This is already the case for column filters: the filter icon is gray or black when it is disabled or enabled.

Something similar can be applied to the global filter button, but in that case it could be blue when enabled and black when disabled. Like in the Network tab in Chrome Dev tools:

filter indicator chrome devtools

Minimal reproduction of the problem with instructions

  1. Go to https://stark.nbb.be/showcase/latest/demo-ui/table and enable the global filter in any of the tables.
  2. Click on any action, paginate the data, etc. There is no clear indication that the global filter is enabled.

What is the motivation / use case for changing the behavior?

Better UX.

Environment


Stark version: 10.0.0-beta.7

@christophercr christophercr added this to the 10.0.0-beta.8 milestone May 29, 2019
@christophercr christophercr added this to To do in 10.0.0-beta.8 via automation May 29, 2019
@christophercr christophercr self-assigned this Jun 3, 2019
@christophercr christophercr moved this from To do to In progress in 10.0.0-beta.8 Jun 3, 2019
christophercr added a commit to christophercr/stark that referenced this issue Jun 3, 2019
@christophercr christophercr moved this from In progress to Review in progress in 10.0.0-beta.8 Jun 3, 2019
christophercr added a commit to christophercr/stark that referenced this issue Jun 4, 2019
christophercr added a commit to christophercr/stark that referenced this issue Jun 4, 2019
christophercr added a commit to christophercr/stark that referenced this issue Jun 4, 2019
@christophercr
Copy link
Collaborator Author

As discussed with @SuperITMan, to keep consistency, we will apply the same color change as we do with the filter icon in the columns (black when the filter is applied and gray when it is not).

10.0.0-beta.8 automation moved this from Review in progress to Done Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
10.0.0-beta.8
  
Done
1 participant