Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: http #96

Closed
dsebastien opened this issue Mar 2, 2018 · 2 comments · Fixed by #268
Closed

core: http #96

dsebastien opened this issue Mar 2, 2018 · 2 comments · Fixed by #268
Labels
comp: stark-core Stark Core must
Milestone
10.0.0-alpha.2

Comments

@dsebastien
Copy link
Contributor

dsebastien commented Mar 2, 2018 •
edited
Loading

Add support for NBB's REST design guide with our http api on top of NG5+'s http service
Keep our current model with cerialize.

Should be a dedicated sub-package and module in stark-core

Ref: https://angular.io/guide/http
@dsebastien dsebastien added this to the 10.0.0-alpha.1 milestone Mar 2, 2018
@dsebastien
Copy link
Contributor Author

blocked by #73

christophercr referenced this issue in christophercr/stark Mar 14, 2018
@christophercr
feat(http): implement Stark Http in stark-core (unit tests to be comp…
719d92d 
…leted) [#96]
@christophercr christophercr mentioned this issue Mar 14, 2018
Merged
3 tasks
SuperITMan pushed a commit that referenced this issue Mar 15, 2018
@christophercr @SuperITMan
feat(http): implement Stark Http in stark-core (unit tests to be comp…
579c59b 
…leted) [#96]
christophercr referenced this issue in christophercr/stark Mar 16, 2018
@christophercr
fix(http) remove redundant JSDocs because Angular ngc compiler throws…
1e8a6cf 
… an error due to these redundant comments [#96]
@christophercr
Copy link
Collaborator

christophercr commented Mar 16, 2018 •
edited
Loading

@dsebastien, @SuperITMan, @ncedric: Just to let you know that currently the build of stark-core fails due to these 2 errors:

christophercr referenced this issue in christophercr/stark Mar 21, 2018
@christophercr
feat(http): create StarkHttp module. Fixed imports. Implemented small…
201edb8 
… demo in Starter [#96]
@christophercr christophercr mentioned this issue Mar 21, 2018
Merged
3 tasks
@christophercr christophercr self-assigned this Mar 21, 2018
christophercr referenced this issue in christophercr/stark Mar 23, 2018
@christophercr
fix(http): fix unit tests. Enhance http demo in Starter [#96]
db5b6b0
@christophercr christophercr mentioned this issue Mar 23, 2018
Merged
3 tasks
dsebastien pushed a commit that referenced this issue Mar 23, 2018
@christophercr @dsebastien
fix(http): fix unit tests. Enhance http demo in Starter (#268)
6d609b8 
* feat(stark-testing): create separate stark-testing package. Replace testing specific dependencies by stark-testing in all stark packages and starter. Fixes #68. [#68][#84][#93]

* chore(stark-testing): upgrade dependencies in stark-testing package. Upgrade @types/node in all packages

* fix(stark-testing): downgrade 'jasmine-core' dependency due to an issue with Zone.js (angular/zone.js#1015)

* fix(starter): clean up tsconfig.spec.json for unit testing

* fix(http): fix unit tests. Enhance http demo in Starter [#96]
@RobbyDeLaet RobbyDeLaet mentioned this issue Apr 19, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-core Stark Core must
Projects
None yet
Milestone
10.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

fix(http): fix unit tests. Enhance http demo in Starter christophercr/stark
2 participants
@dsebastien @christophercr