feat(stark-ui): add show/hide columns functionality to tables #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophercr
suggested changes
Feb 21, 2019
packages/stark-ui/src/modules/minimap/components/minimap.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/minimap/components/minimap.component.spec.ts
Show resolved
Hide resolved
packages/stark-ui/src/modules/minimap/components/minimap.component.html
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/minimap/components/minimap.component.spec.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/table/components/table.component.ts
Outdated
Show resolved
Hide resolved
carlo-nomes
force-pushed
the
feature/show-hide-table-columns
branch
2 times, most recently
from
1dd05e4
to
6efd141
Compare
|
@christophercr I updated the PR. |
carlo-nomes
force-pushed
the
feature/show-hide-table-columns
branch
from
6efd141
to
19d2905
Compare
| </div> | ||
| </ng-container> | ||
| <stark-minimap | ||
| [matTooltip]="'STARK.TABLE.TOGGLE_COLUMNS' | translate" |
There was a problem hiding this comment.
I think the translation we have for this key is not correct... it says "Column filters" but it is not to filter columns. I suggest to change it to "Show/Hide columns".
I think the same translation key is used in the column.component.html but in that case the "Column filter" does make sense... so we are definitly missing one translation key specifically for the Minimap in the Table
There was a problem hiding this comment.
Updated the PR. 😄
carlo-nomes
force-pushed
the
feature/show-hide-table-columns
branch
2 times, most recently
from
1ed81c3
to
6f2f668
Compare
christophercr
approved these changes
Feb 22, 2019
christophercr
changed the title
- update minimap component - update tests for minimap component - refactor column visibility property CLOSES: NationalBankBelgium#522
carlo-nomes
force-pushed
the
feature/show-hide-table-columns
branch
from
6f2f668
to
69b56f0
Compare
|
@christophercr, could you merge this? PR #1152 depends on this PR. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #522
What is the new behavior?
Minimap is integrated with table and column can be hidden / shown by the user
Does this PR introduce a breaking change?
The implementation of the minimap and table component has changed slightly
Other information