fix(stark-ui): cellFormatter is now called even when the rawValue is undefined #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophercr
changed the title
| component.ngAfterViewInit(); | ||
| }); | ||
|
|
||
| it("should display 'ONE' instead of '1' when id == '1'", () => { |
There was a problem hiding this comment.
Let's put in the test description only the functionality tested instead of the specific details... for example: should display the formatted value in the cell instead of the raw value
| expect(rowIdElements[0].innerText).toEqual("one"); | ||
| }); | ||
|
|
||
| it("should display '-null-' when 'description' is undefined", () => { |
There was a problem hiding this comment.
same remark about the test description, what about: should display the formatted value in the cell even if the raw value is undefined ?
| expect(rowIdElements[1].innerText).toEqual("-null-"); | ||
| }); | ||
|
|
||
| it("should NOT display anything when 'test' is undefined and no 'cellFormatter' property is set for the column", () => { |
There was a problem hiding this comment.
same remark about the test description, what about: should NOT display anything when the raw value is undefined and there is no 'cellFormatter' defined for the column ?
SuperITMan
force-pushed
the
bugfix/table-cellformatter-not-triggered
branch
2 times, most recently
from
cae23cb
to
397bec8
Compare
|
PR updated. @christophercr @nicanac Could you please check it ? 😊 |
…matter is not called ISSUES CLOSED: #1465
SuperITMan
force-pushed
the
bugfix/table-cellformatter-not-triggered
branch
from
397bec8
to
815ac6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #1465
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1465
What is the new behavior?
cellFormatteris now triggered even if therawValueis undefined.Does this PR introduce a breaking change?
Other information