Revert "chore(deps): bump @mdi/angular-material in /packages/stark-ui"

[SuperITMan]

This reverts commit 3ac874e.

ISSUES CLOSED: #1762

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Wrong update of @mdi/angular-material dependency.

Issue Number: #1762

What is the new behavior?

Revert wrong commit.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

[coveralls]

Coverage remained the same at 86.366% when pulling 6fdf466 on SuperITMan:bugfix/revert-mdi-update into 4e8d22a on NationalBankBelgium:master.

[christophercr]

I think you should also adapt the dependabot config to avoid any future upgrade of this dependency 😉

[christophercr]

It seems dependabot was faster than us... and it already upgraded to a newer version yesterday: #1832 😆

[nicanac]

Yes, but it's a good new, it seems to work well

[christophercr]

@nicanac In fact it's not good... we should adapt this PR to prevent dependabot from keeping upgrading @mdi/angular-material

[SuperITMan]

@christophercr if we ask dependabot to not update the dependency, we should create an issue to not forget to update it 😊
If we do so, you're probably right that it would be better to lock it on the version 4.x.
I adapt the PR

@nicanac there are breaking changes in the icons, such as "github" icon.

We should maybe have a look on svg-to-ts library. Could be useful to have compilation issues if an icon changes 😊