Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix release gh pages publish author #2539

Conversation

SuperITMan
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Release 10.2.0 of Stark got an issue on GtiHub Actions due to author name "GitHub Actions CI".

What is the new behavior?

Author name has been fixed in gh-deploy script.

As we are going to start the migration to NG 11, the PR adds support for builds of branches like 10.2.x, 10.1.x, etc.

Like this, it will be easy for us to provide bugfixes on release 10.2.x if needed, while we are working on Stark 11.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@SuperITMan SuperITMan added the comp: build-main Main build label Mar 10, 2021
@SuperITMan SuperITMan added this to the 11.0.0 milestone Mar 10, 2021
@SuperITMan SuperITMan requested a review from nicanac March 10, 2021 16:29
@SuperITMan SuperITMan added this to In progress in 12.0.0 via automation Mar 10, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.437% when pulling 35e9b6d on SuperITMan:bugfix/fix-release-gh-pages-publish-author into f34c50d on NationalBankBelgium:master.

12.0.0 automation moved this from In progress to Reviewer approved Mar 15, 2021
Copy link
Contributor

@nicanac nicanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nicanac nicanac merged commit 99a0664 into NationalBankBelgium:master Mar 15, 2021
12.0.0 automation moved this from Reviewer approved to Done Mar 15, 2021
@SuperITMan SuperITMan modified the milestones: 12.0.0, 12.0.0-beta.0 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
12.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants