feat(build): added release support. Closes #54. Closes #24 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsebastien
force-pushed
the
feature/release
branch
from
a04a9a3
to
661458d
Compare
Pull Request Test Coverage Report for Build 198
💛 - Coveralls |
Pull Request Test Coverage Report for Build 218
💛 - Coveralls |
dsebastien
force-pushed
the
feature/release
branch
2 times, most recently
from
4b2de79
to
c938207
Compare
dsebastien
force-pushed
the
feature/release
branch
2 times, most recently
from
0f8725d
to
a65e122
Compare
7 tasks
| Once the tag is pushed to GitHub, Travis picks it up and initiates a build. | ||
| Travis executes builds, tests, then executes `npm run release:publish`. | ||
|
|
||
| That script makes some checks then, if all succeed it publishes the different packages on npm. |
There was a problem hiding this comment.
Question... what if something goes wrong during these checks? what if this process fails? how to re-trigger the publish?
There was a problem hiding this comment.
Let's be optimistic for now: we'll use tag until we face an issue.
If we do face an issue, then we can switch to checking the commit message instead and make sure we can do the publish locally and not only through Travis
| * creates a new git tag and pushes it | ||
| * creates a github release page and makes it final | ||
|
|
||
| After this, the release is tagged and visible on github |
There was a problem hiding this comment.
Where does the commit "chore(release): release %s" is actually done?
There was a problem hiding this comment.
As discussed, it's used by release it when release:prepare is executed.
dsebastien
force-pushed
the
feature/release
branch
from
a65e122
to
108e077
Compare
dsebastien
force-pushed
the
feature/release
branch
from
108e077
to
101ceab
Compare
christophercr
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Adds the possibility to release and publish a release in an automated fashion using Travis
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information