Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-ui): Ui: replace text-mask to imask.js #3384

Closed
wants to merge 21 commits into from

Conversation

mhenkens
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2564

What is the new behavior?

Does this PR introduce a breaking change?

[X] Yes
[ ] No

Other information

@mhenkens mhenkens requested a review from SuperITMan June 17, 2022 12:55
@coveralls
Copy link

coveralls commented Jun 17, 2022

Coverage Status

Coverage decreased (-2.6%) to 85.648% when pulling 5185a37 on mhenkens:master into c728128 on NationalBankBelgium:master.

@mhenkens mhenkens requested a review from SuperITMan June 20, 2022 11:06
Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @mhenkens

Thanks for your first PR on Stark. It seems great ! 👍
I made some comments for some parts of the code to adapt.
Please pay attention to document any property / class / method defined in your code. It is important for the documentation available on https://stark.nbb.be/api-docs/stark-ui/latest/index.html. FYI you can check the result of the documentation by running the command npm run docs:stark-ui:serve from the root folder of Stark.

In order to simplify the final CHANGELOG of the next version of Stark, could you rebase and squash your commits as documented in the CONTRIBUTING guide: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#proposing-your-changes-by-submitting-a-pull-request-pr ?
At the end, you should have only 2 commits, one for the new feature (replacement of angular2-text-mask by imask in stark-ui), the other one for the changes in the showcase in order to use the new implementation of the directive.

Also, it would be interesting that you work on another branch than your master branch for this feature in order to be able to work on another feature or bugfix in parallel 😊
You can check the documentation about our workflow on https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#workflow

Alexis

@SuperITMan SuperITMan added this to the 12.0.0-rc.0 milestone Jun 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mhenkens mhenkens closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants