Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(stark-build): docs for base url and deploy url customization support #385

Merged

Conversation

christophercr
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #148

What is the new behavior?

Docs describing the new feature.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@christophercr
Copy link
Collaborator Author

christophercr commented May 23, 2018

@dsebastien, @SuperITMan could you have a look on the doc I added and tell me what you think?

@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage increased (+0.01%) to 93.785% when pulling bb29f0e on christophercr:feature/basehref-docs into 39d1b43 on NationalBankBelgium:master.

@dsebastien dsebastien merged commit bb4b0b1 into NationalBankBelgium:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants