Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stark-demo): cleanup of Stark Showcase application #426

Merged
merged 1 commit into from
Jun 11, 2018
Merged

refactor(stark-demo): cleanup of Stark Showcase application #426

merged 1 commit into from
Jun 11, 2018

Conversation

RobbyDeLaet
Copy link
Contributor

Applied the same changes that where made to the Starter app.

ISSUES CLOSED: #422

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The ShowCase application is not following the same guidelines and structure as the Starter application.

Issue Number: #422

What is the new behavior?

The ShowCase and Starter application are following the same guidelines and structure.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@christophercr christophercr changed the title feat(stark-demo): cleanup of Stark Showcase application refactor(stark-demo): cleanup of Stark Showcase application Jun 11, 2018
@coveralls
Copy link

coveralls commented Jun 11, 2018

Coverage Status

Coverage decreased (-0.01%) to 94.246% when pulling c0a0163 on RobbyDeLaet:feature/CleanupShowcase into 0ced55c on NationalBankBelgium:master.

Applied the same changes that where made to the Starter app.

ISSUES CLOSED: #422
@christophercr christophercr merged commit f19eb62 into NationalBankBelgium:master Jun 11, 2018
@dsebastien dsebastien added this to the 10.0.0-alpha.3 milestone Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showcase: clean up
4 participants