Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-demo): add baseHref dynamically via Angular provider to fix Showcase when published in GitHub pages #471

Conversation

christophercr
Copy link
Collaborator

@christophercr christophercr commented Jun 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #466

What is the new behavior?

The base href of the showcase is set dynamically via the Angular APP_BASE_HREF provider as an environment provider instead of setting it in the angular.json file in order to handle the final location of the app in GitHub pages (defined in environment.prod.ts).

The handling of the environment files in Webpack is works correctly now due to some minor fixes in the build-utils.js file.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

… Showcase when published in GitHub pages

ISSUES CLOSED: #466
@dsebastien dsebastien merged commit b1e17f6 into NationalBankBelgium:master Jun 29, 2018
christophercr referenced this pull request in christophercr/stark Jul 2, 2018
…ly via Node script to fix Showcase when published in GitHub pages

ISSUES CLOSED: 466
christophercr referenced this pull request in christophercr/stark Jul 2, 2018
…ly via Node script to fix Showcase when published in GitHub pages

ISSUES CLOSED: 466
dsebastien added a commit that referenced this pull request Jul 2, 2018
fix(stark-demo): revert PR #471. Adapt baseHref/deployUrl via Node script to fix Showcase publication on GitHub pages
@SuperITMan SuperITMan added this to Done in 10.0.0-alpha.4 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants