Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-ui): include only "src" and "assets" folders in "lint-css" command #527

Conversation

christophercr
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

As a result of the PR #516, the new lint-css command in stark-core and stark-ui also lints the CSS files in the "coverage" and "reports" folders which are created by the unit tests. This causes the lint-css command to fail due to many violations which should not be in the scope of the linting.

What is the new behavior?

The lint-css command in stark-core and stark-ui only includes the files from the "src" and "assets" folders.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@christophercr christophercr merged commit 0c770ce into NationalBankBelgium:master Jul 18, 2018
@christophercr christophercr deleted the feature/stylelint-exclusions branch July 18, 2018 08:52
@SuperITMan SuperITMan added this to Done in 10.0.0-alpha.4 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants