feat(stark-ui): implementation of minimap component #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperITMan
reviewed
Nov 5, 2018
| export const translationsEn: object = { | ||
| STARK: { | ||
| TABLE: { | ||
| TOGGLE_COLUMNS: "Column filters" |
There was a problem hiding this comment.
Could you please move this translation in stark-core/src/common/translations/translations ? 😊
Like this all the translations are in the same location
Mallikki
force-pushed
the
feature/stark-minimap
branch
from
2026fff
to
fa15c2e
Compare
3 tasks
christophercr
suggested changes
Nov 5, 2018
| /* ============================================================================== */ | ||
| /* S t a r k M i n i m a p */ | ||
| /* ============================================================================== */ | ||
| /* stark-ui: src/modules/minimap/components/minimap-theme.scss */ |
There was a problem hiding this comment.
The theme.scss file should contain only "themable" properties, meaning that only colors, backgrounds, fill colors, foregrounds, etc should be defined in this file
So let's move all the other CSS rules like top, left, right, etc to the _minimap.component.scss file ;)
Mallikki
force-pushed
the
feature/stark-minimap
branch
from
fa15c2e
to
c972fc3
Compare
| /* ============================================================================== */ | ||
| /* S t a r k M i n i m a p */ | ||
| /* ============================================================================== */ | ||
| /* stark-ui: src/modules/minimap/components/minimap-theme.scss */ |
There was a problem hiding this comment.
Now the pop-up div with the different checkboxes has no border and even its background is different, it is not white anymore so it is hard to distinguish it from the page background 😕
Mallikki
force-pushed
the
feature/stark-minimap
branch
from
c972fc3
to
9965ae8
Compare
Mallikki
force-pushed
the
feature/stark-minimap
branch
from
9965ae8
to
4148d7d
Compare
christophercr
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #758
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number: #758
What is the new behavior?
The minimap composent is now implemented
Does this PR introduce a breaking change?
Other information