-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added most recent equivalent unique functions #2339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ivakegg
commented
Apr 5, 2024
- Simply add MOST_RECENT_ in front of the function name
* Simply add MOST_RECENT_ in front of the function name
apmoriarty
previously approved these changes
Apr 8, 2024
avgAGB
previously approved these changes
Apr 9, 2024
MiguelRicardos
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds find. Looks good. Just one small change on a comment.
.../query-core/src/main/java/datawave/query/language/functions/jexl/MostRecentUniqueByHour.java
Outdated
Show resolved
Hide resolved
MiguelRicardos
approved these changes
Apr 10, 2024
avgAGB
approved these changes
Apr 11, 2024
apmoriarty
approved these changes
Apr 16, 2024
hgklohr
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Revert "Updated to ensure the most recent unique functions parse correctly." This reverts commit d0aa266. * Revert "Fixes to the most-recent-unique functionality (#2392)" This reverts commit 5b4eb71. * Revert "Fixed bug where unique results of null values failed to return (#2354)" This reverts commit 15f08a3. * Revert "Added most recent equivalent unique functions (#2339)" This reverts commit bb8d353. * Revert "Most recent unique feature (#1991)" This reverts commit a4587af. * Updated centos dockerfiles to use yum repo mirror * Update quickstart docker image to Rocky Linux 8 (#2454) (#2455) * Update quickstart docker image to Rocky Linux 8 (#2454) * Revert "Updated centos dockerfiles to use yum repo mirror" This reverts commit d41e886. * Added the hdfs sorted set builder mechanism back in --------- Co-authored-by: Whitney O'Meara <james.w.omeara@gmail.com> Co-authored-by: Keith Ratcliffe <ratcliffe.keith@gmail.com>
ivakegg
added a commit
that referenced
this pull request
Jul 10, 2024
* Revert "Updated to ensure the most recent unique functions parse correctly." This reverts commit d0aa266. * Revert "Fixes to the most-recent-unique functionality (#2392)" This reverts commit 5b4eb71. * Revert "Fixed bug where unique results of null values failed to return (#2354)" This reverts commit 15f08a3. * Revert "Added most recent equivalent unique functions (#2339)" This reverts commit bb8d353. * Revert "Most recent unique feature (#1991)" This reverts commit a4587af. * Updated centos dockerfiles to use yum repo mirror * Update quickstart docker image to Rocky Linux 8 (#2454) (#2455) * Update quickstart docker image to Rocky Linux 8 (#2454) * Revert "Updated centos dockerfiles to use yum repo mirror" This reverts commit d41e886. * Added the hdfs sorted set builder mechanism back in --------- Co-authored-by: Whitney O'Meara <james.w.omeara@gmail.com> Co-authored-by: Keith Ratcliffe <ratcliffe.keith@gmail.com>
ivakegg
added a commit
that referenced
this pull request
Jul 10, 2024
* Revert "Updated to ensure the most recent unique functions parse correctly." This reverts commit d0aa266. * Revert "Fixes to the most-recent-unique functionality (#2392)" This reverts commit 5b4eb71. * Revert "Fixed bug where unique results of null values failed to return (#2354)" This reverts commit 15f08a3. * Revert "Added most recent equivalent unique functions (#2339)" This reverts commit bb8d353. * Revert "Most recent unique feature (#1991)" This reverts commit a4587af. * Updated centos dockerfiles to use yum repo mirror * Update quickstart docker image to Rocky Linux 8 (#2454) (#2455) * Update quickstart docker image to Rocky Linux 8 (#2454) * Revert "Updated centos dockerfiles to use yum repo mirror" This reverts commit d41e886. * Added the hdfs sorted set builder mechanism back in --------- Co-authored-by: Whitney O'Meara <james.w.omeara@gmail.com> Co-authored-by: Keith Ratcliffe <ratcliffe.keith@gmail.com>
hgklohr
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Revert "Updated to ensure the most recent unique functions parse correctly." This reverts commit d0aa266. * Revert "Fixes to the most-recent-unique functionality (#2392)" This reverts commit 5b4eb71. * Revert "Fixed bug where unique results of null values failed to return (#2354)" This reverts commit 15f08a3. * Revert "Added most recent equivalent unique functions (#2339)" This reverts commit bb8d353. * Revert "Most recent unique feature (#1991)" This reverts commit a4587af. * Updated centos dockerfiles to use yum repo mirror * Update quickstart docker image to Rocky Linux 8 (#2454) (#2455) * Update quickstart docker image to Rocky Linux 8 (#2454) * Revert "Updated centos dockerfiles to use yum repo mirror" This reverts commit d41e886. * Added the hdfs sorted set builder mechanism back in --------- Co-authored-by: Whitney O'Meara <james.w.omeara@gmail.com> Co-authored-by: Keith Ratcliffe <ratcliffe.keith@gmail.com>
hgklohr
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Revert "Updated to ensure the most recent unique functions parse correctly." This reverts commit d0aa266. * Revert "Fixes to the most-recent-unique functionality (#2392)" This reverts commit 5b4eb71. * Revert "Fixed bug where unique results of null values failed to return (#2354)" This reverts commit 15f08a3. * Revert "Added most recent equivalent unique functions (#2339)" This reverts commit bb8d353. * Revert "Most recent unique feature (#1991)" This reverts commit a4587af. * Updated centos dockerfiles to use yum repo mirror * Update quickstart docker image to Rocky Linux 8 (#2454) (#2455) * Update quickstart docker image to Rocky Linux 8 (#2454) * Revert "Updated centos dockerfiles to use yum repo mirror" This reverts commit d41e886. * Added the hdfs sorted set builder mechanism back in --------- Co-authored-by: Whitney O'Meara <james.w.omeara@gmail.com> Co-authored-by: Keith Ratcliffe <ratcliffe.keith@gmail.com> Conflicts: warehouse/query-core/src/main/java/datawave/query/util/sortedset/RewritableSortedSetImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.