Address spotbugs issues with TableConfigCache code #897
Conversation
drewfarris
requested review from
alerman,
apmoriarty,
billoley,
cawaring,
hlgp,
ivakegg,
jschmidt10,
jwomeara,
keith-ratcliffe and
matthpeterson
as code owners
|
|
||
| public TableConfigCache(Configuration conf) { | ||
| super(conf); | ||
| } | ||
|
|
||
| @SuppressFBWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD") |
There was a problem hiding this comment.
It seems like this was the best action to take here - it was complaining that we were writing to a static field from a non-static method. Perhaps there's another way to do this that would not result in a warning?
There was a problem hiding this comment.
I'll investigate this when I get back. Approving for now. Long term we shouldn't need this suppression.
There was a problem hiding this comment.
Looks like configMap is static but we're setting it in a non-static method. The method actually has no dependency on any instance state. Seems like the fix might be to make this method static.
There was a problem hiding this comment.
@jschmidt10 - I suspected the same thing but was going to leave the design up to @hlgp.
|
|
||
| public TableConfigCache(Configuration conf) { | ||
| super(conf); | ||
| } | ||
|
|
||
| @SuppressFBWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD") |
There was a problem hiding this comment.
I'll investigate this when I get back. Approving for now. Long term we shouldn't need this suppression.
…s than requested page size, update status
…page less than requested page size, update status" This reverts commit 76f0d0f.
No description provided.