Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max of 50 to computed agents. #157

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Add max of 50 to computed agents. #157

merged 1 commit into from
Sep 29, 2021

Conversation

cfkoehler
Copy link
Collaborator

The configurable property can override this.

@cfkoehler cfkoehler added the tech-debt Low-impact cleanup and upkeep label Jun 14, 2021
@cfkoehler cfkoehler self-assigned this Jun 14, 2021
jpdahlke
jpdahlke requested changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@jpdahlke jpdahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test. Recommend possibly creating a getMaxMemory() method to leverage/override in test to provide maxMem value rather than messing with the Runtime.

@jpdahlke jpdahlke added this to the v6.7.0 milestone Jun 17, 2021
@cfkoehler cfkoehler requested review from jdcove2 and removed request for dlmarion July 23, 2021 13:58
@cfkoehler
Copy link
Collaborator Author

Added a test class and test's for the computePoolSize. Change it to take in a parameter of max memory.

@cfkoehler cfkoehler force-pushed the MaxAgentsWhenCalculated branch 5 times, most recently from 0a40d16 to 94363f0 Compare July 23, 2021 17:26
@cfkoehler cfkoehler requested a review from jpdahlke July 23, 2021 17:29
@cfkoehler cfkoehler force-pushed the MaxAgentsWhenCalculated branch 2 times, most recently from 4a09274 to ffd0c70 Compare July 23, 2021 19:02
@jpdahlke jpdahlke merged commit c607eec into NationalSecurityAgency:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdahlke jpdahlke jpdahlke approved these changes

@jdcove2 jdcove2 jdcove2 approved these changes

Assignees

@cfkoehler cfkoehler

Labels
tech-debt Low-impact cleanup and upkeep
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cfkoehler @jpdahlke @jdcove2