-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max of 50 to computed agents. #157
Merged
jpdahlke
merged 1 commit into
NationalSecurityAgency:master
from
cfkoehler:MaxAgentsWhenCalculated
Sep 29, 2021
Merged
Add max of 50 to computed agents. #157
jpdahlke
merged 1 commit into
NationalSecurityAgency:master
from
cfkoehler:MaxAgentsWhenCalculated
Sep 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdahlke
requested changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test. Recommend possibly creating a getMaxMemory() method to leverage/override in test to provide maxMem value rather than messing with the Runtime.
Added a test class and test's for the computePoolSize. Change it to take in a parameter of max memory. |
0a40d16
to
94363f0
Compare
4a09274
to
ffd0c70
Compare
jdcove2
approved these changes
Jul 23, 2021
jpdahlke
reviewed
Sep 29, 2021
jpdahlke
reviewed
Sep 29, 2021
ffd0c70
to
5a9b00e
Compare
5a9b00e
to
136de6d
Compare
jpdahlke
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configurable property can override this.