Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComparisonPlace. #644

Merged
merged 5 commits into from Apr 5, 2024

Conversation

jdcove2
Copy link
Collaborator

@jdcove2 jdcove2 commented Jan 10, 2024

This PR adds ComparisonPlace. ComparisonPlace runs the configured two places and gives them identical IBDO's. ComparisonPlace then compares the output of the two places and logs any differences.

@jdcove2 jdcove2 added the test-only The change only impacts test code label Jan 11, 2024
@cfkoehler
Copy link
Collaborator

@jdcove2 why is this label as 'test-only' when this is a new place and feature.
I would have expected to see this labeled as 'feature'. Probably something that will never be run on a production system but still doing more then just creating/modifying java test code.

Happy to be proven wrong. I have not fully digested this PR yet.

@jdcove2
Copy link
Collaborator Author

jdcove2 commented Feb 12, 2024

"Typo" -- I will remove it.

@jdcove2 jdcove2 removed the test-only The change only impacts test code label Feb 12, 2024
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested

src/main/java/emissary/place/ComparisonPlace.java Outdated Show resolved Hide resolved
src/main/java/emissary/place/ComparisonPlace.java Outdated Show resolved Hide resolved
src/main/java/emissary/place/ComparisonPlace.java Outdated Show resolved Hide resolved
src/main/java/emissary/place/ComparisonPlace.java Outdated Show resolved Hide resolved
src/main/java/emissary/place/ComparisonPlace.java Outdated Show resolved Hide resolved
@drivenflywheel drivenflywheel added the rebase Things have happened and now a rebase is needed label Feb 12, 2024
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase. Unit tests in this PR were broken by PR #664, and merging this PR in its current state will prevent master from building.

@jdcove2 jdcove2 removed the rebase Things have happened and now a rebase is needed label Feb 13, 2024
@jpdahlke jpdahlke added this to the v8.0.0-M16 milestone Mar 18, 2024
@rpg36 rpg36 self-requested a review March 28, 2024 09:46
@jpdahlke jpdahlke removed this from the v8.0.0-M16 milestone Mar 29, 2024
Copy link
Collaborator

@rpg36 rpg36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but bringing up the concern that this place will introduce invisible places. So it might conflict with the work that was done recently to address invisible places.

@jdcove2
Copy link
Collaborator Author

jdcove2 commented Apr 1, 2024

I plan to put up another PR to address the "invisible place" issue once this one is merged. Since this place should never be used except locally or on a development system, approving and merging it should not cause any problems.

@jpdahlke jpdahlke added this to the v8.1.0 milestone Apr 2, 2024
@jpdahlke jpdahlke merged commit d53a10e into NationalSecurityAgency:main Apr 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants