Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SONAR warnings for IBaseDataObjectDiffHelper. #664

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Fix SONAR warnings for IBaseDataObjectDiffHelper. #664

merged 1 commit into from
Feb 10, 2024

Conversation

jdcove2
Copy link
Collaborator

@jdcove2 jdcove2 commented Jan 30, 2024

This PR fixes the below two SONAR warnings for emissary.core.IBaseDataObjectDiffHelper:

  • "Define a constant instead of duplicating this literal "parameters" 3 times."
  • "Define a constant instead of duplicating this literal "%s%s: %s : %s" 3 times."

@cfkoehler cfkoehler added the tech-debt Low-impact cleanup and upkeep label Feb 9, 2024
@cfkoehler cfkoehler added this to the v8.0.0-M14 milestone Feb 9, 2024
@jpdahlke jpdahlke merged commit c668fa1 into NationalSecurityAgency:master Feb 10, 2024
9 checks passed
@drivenflywheel drivenflywheel mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemperFidelisTyrannosaurus SemperFidelisTyrannosaurus SemperFidelisTyrannosaurus approved these changes

@sambish5 sambish5 sambish5 approved these changes

Assignees
No one assigned
Labels
tech-debt Low-impact cleanup and upkeep
Projects
None yet
Milestone
v8.0.0-M14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdcove2 @SemperFidelisTyrannosaurus @sambish5 @jpdahlke @cfkoehler