Sealing on empty file patch #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-carr
reviewed
Sep 8, 2020
tpm2/src/util/tpm2_kmyth_seal.c
Outdated
| @@ -665,6 +665,14 @@ int kmyth_wrap_input(char *inPath, | |||
| return 1; | |||
| } | |||
| kmyth_log(LOG_DEBUG, "read in %d bytes of data to be wrapped", data_length); | |||
|
|
|||
| // validate non-empty plaintext buffer specified | |||
| if (data_length == 0) | |||
There was a problem hiding this comment.
For completeness we should also check that data is not NULL.
There was a problem hiding this comment.
I apologize, my earlier comment wasn't clear. I meant that we should check that data is not NULL in addition to checking that data_length is not zero before using it, I wasn't suggesting to check that data is not NULL before freeing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in
kmyth_wrap_inputinsrc/util/tpm2_kmyth_seal.cto validate that the file being sealed is not empty.