Fixed issue with updating nested properties via binding.

NativeScript · Jun 10, 2015 · ffc1fcb · ffc1fcb
1 parent 0dc6156
commit ffc1fcb
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/apps/tests/ui/bindable-tests.ts b/apps/tests/ui/bindable-tests.ts
@@ -541,4 +541,36 @@ export function test_BindingToDictionaryAtAppLevel() {
     }
 
     helper.buildUIAndRunTest(createLabel(), testFunc);
+}
+
+export function test_UpdatingNestedPropertyViaBinding() {
+    var expectedValue1 = "Alabala";
+    var expectedValue2 = "Tralala";
+    var viewModel = new observable.Observable();
+    var parentViewModel = new observable.Observable();
+    viewModel.set("parentView", parentViewModel);
+    parentViewModel.set("name", expectedValue1);
+
+    var testElement: bindable.Bindable = new bindable.Bindable();
+
+    testElement.bind({
+        sourceProperty: "parentView.name",
+        targetProperty: "targetName",
+        twoWay: true
+    }, viewModel);
+
+    var testElement2: bindable.Bindable = new bindable.Bindable();
+
+    testElement2.bind({
+        sourceProperty: "parentView.name",
+        targetProperty: "targetProperty",
+        twoWay: true
+    }, viewModel);
+
+    TKUnit.assertEqual(testElement.get("targetName"), expectedValue1);
+
+    testElement.set("targetName", expectedValue2);
+
+    TKUnit.assertEqual(parentViewModel.get("name"), expectedValue2);
+    TKUnit.assertEqual(testElement2.get("targetProperty"), expectedValue2);
 }
diff --git a/ui/core/bindable.ts b/ui/core/bindable.ts
@@ -261,7 +261,7 @@ export class Binding {
             else {
                 this.updateTarget(expressionValue);
             }
-        } else if (data.propertyName === this.options.sourceProperty) {
+        } else if (data.propertyName === this.sourceOptions.property) {
             this.updateTarget(data.value);
         }
     }