Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scoped Packages #7911

Merged
merged 60 commits into from
Oct 16, 2019
Merged

feat: Scoped Packages #7911

merged 60 commits into from
Oct 16, 2019

Conversation

vakrilov
Copy link
Contributor

@vakrilov vakrilov commented Oct 7, 2019

PR Checklist

Introduce @nativescript/core package.

Related to #4041 #7895

@cla-bot cla-bot bot added the cla: yes label Oct 7, 2019
@SvetoslavTsenov
Copy link
Contributor

test

@vakrilov vakrilov force-pushed the scoped-packages-generate-master branch 3 times, most recently from 42160e5 to f0c50e0 Compare October 10, 2019 20:02
@vakrilov vakrilov marked this pull request as ready for review October 11, 2019 20:42
@vakrilov vakrilov force-pushed the scoped-packages-generate-master branch 2 times, most recently from 3f584b3 to 864b444 Compare October 11, 2019 21:13
@SvetoslavTsenov
Copy link
Contributor

test --ignore ngapps api24 ios12

MartoYankov
MartoYankov reviewed Oct 14, 2019
View reviewed changes
DevelopmentWorkflow.md Outdated Show resolved Hide resolved
DevelopmentWorkflow.md Outdated Show resolved Hide resolved
nativescript-core/http/http-request/http-request.android.ts Outdated Show resolved Hide resolved
nativescript-core/index.d.ts Outdated Show resolved Hide resolved
nativescript-core/index.d.ts Outdated Show resolved Hide resolved
nativescript-core/index.ts Outdated Show resolved Hide resolved
nativescript-core/index.ts Outdated Show resolved Hide resolved
nativescript-core/index.d.ts Show resolved Hide resolved
@vakrilov vakrilov force-pushed the scoped-packages-generate-master branch from 49bea9c to d44d249 Compare October 15, 2019 06:29
@SvetoslavTsenov
Copy link
Contributor

test --ignore ngapps branch_nativescript_dev_webpack#ns-scope-in-host-resolver ios12 api24

MartoYankov
MartoYankov reviewed Oct 15, 2019
View reviewed changes
nativescript-core/ui/core/control-state-change/control-state-change.android.ts Outdated Show resolved Hide resolved
nativescript-core/ui/dialogs/dialogs-common.ts Outdated Show resolved Hide resolved
nativescript-core/ui/index.d.ts Outdated Show resolved Hide resolved
nativescript-core/ui/index.d.ts Outdated Show resolved Hide resolved
nativescript-core/ui/index.d.ts Outdated Show resolved Hide resolved
nativescript-core/ui/index.ts Outdated Show resolved Hide resolved
nativescript-core/ui/index.ts Outdated Show resolved Hide resolved
nativescript-core/ui/index.ts Outdated Show resolved Hide resolved
nativescript-core/ui/index.ts Outdated Show resolved Hide resolved
DevelopmentWorkflow.md Show resolved Hide resolved
@SvetoslavTsenov
Copy link
Contributor

test --ignore ngapps branch_nativescript_dev_webpack#ns-scope-in-host-resolver ios12 api24

@SvetoslavTsenov
Copy link
Contributor

test --ignore ngapps ios12 api24

@vakrilov vakrilov force-pushed the scoped-packages-generate-master branch 2 times, most recently from 1c15ae9 to c58ec1f Compare October 15, 2019 13:37
@vakrilov
Copy link
Contributor Author

test --ignore ngapps ios12 api24

@vakrilov
Copy link
Contributor Author

test --ignore

@vakrilov vakrilov force-pushed the scoped-packages-generate-master branch 2 times, most recently from e5abd0c to 4345d3c Compare October 16, 2019 12:55
SvetoslavTsenov and others added 22 commits October 16, 2019 16:47
@SvetoslavTsenov
chore: update NATIVESCRIPT_CORE_ARGS
80d23af
@SvetoslavTsenov
chore: fix compat pack
7b7434b
chore: fix tslint errors
67b73f1
chore: fix ui-test-app build with linked modules
b632585
chore: Application, ApplicationSettings, Connectivity and Http
e32c2c3
chore: export Trace, Profiling and Utils
5b69c4c
refactor: Static create methods for ImageSource
06235a1
chore: fix deprecated usages of ImageSource
83a15a0
chore: move Span and FormattedString to ui
ff0a003
chore: add events-args and ImageSource to index files
7a85180
chore: check for CLI >= 6.2 when building for IOS
d4059aa
chore: update travis build
cf501d8
@SvetoslavTsenov
chore: copy Pod file to compat package
0d561f5
@SvetoslavTsenov
chore: update error msg ui-tests-app
16f05b5
@MartoYankov
refactor: Apply suggestions from code review
3e3314e 
Co-Authored-By: Martin Yankov <m.i.yankov@gmail.com>
chore: typings and refs
1d413f8
chore: add missing d.ts files for public API
657aec4
chore: adress code review FB
24fb668
chore: update api-report
1488137
chore: dev-workflow for other apps
bc4e293
chore: api update
bdb1336
chore: update api-report
babb3a7
@vakrilov vakrilov force-pushed the scoped-packages-generate-master branch from 4345d3c to babb3a7 Compare October 16, 2019 13:53
@SvetoslavTsenov
Copy link
Contributor

test --ignore ngapps api24 ios12

1 similar comment
@vakrilov
Copy link
Contributor Author

test --ignore ngapps api24 ios12

@vakrilov vakrilov merged commit cc97a16 into master Oct 16, 2019
@vakrilov vakrilov deleted the scoped-packages-generate-master branch October 16, 2019 21:45
This was referenced Oct 17, 2019
Closed
Closed
@manoldonev manoldonev mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartoYankov MartoYankov MartoYankov approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vakrilov @SvetoslavTsenov @MartoYankov