New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tooling): wait for emulator before running adb commands #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 |
Plamen5kov
force-pushed
the
plamen5kov/wait-for-emulator
branch
from
January 4, 2018 14:45
caddd6c
to
65ac5c3
Compare
Plamen5kov
force-pushed
the
plamen5kov/wait-for-emulator
branch
from
January 4, 2018 14:52
a3888da
to
f26c787
Compare
💔 |
1 similar comment
💔 |
run ci |
petekanev
suggested changes
Jan 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is based on the reverted master branch. Let's merge #914 before we go ahead with this one?
💔 |
run ci |
💔 |
run ci |
💚 |
run ci |
1 similar comment
run ci |
run CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
We try to run adb commands before the device is ready to receive them. Devices/Emulators may pass through different states like:
device is offline
or the bootup animation is stillrunning
.solution
Make the test tooling wait for the emulator to be fully operation before running any
adb
commands or even installing the app to prevent running commands too early.