refactor(project template): replace runtime project template with user template #891

Plamen5kov · 2017-12-12T16:52:50Z

problem
test-app project in android studio is different than a normal user project template, that causes difficult debugging experience

solution
make test-app project structure resemble user project template closely as possible:

move android-metadata-generator to test-app/build-tools
- all input arguments are in .txt files (makes for easier debugging)
move android-static-binding-generator to test-app/build-tools
- all input arguments are in txt files (makes for easyer debugging)
move android-dts-generator to test-app/build-tools
use build.gradle from project template
- metadata is generated automatically
- static binding generator is ran if needed and input directory is test-app/app/src/main/assets/app
add dts generator as a submodule

expected behavior
no changes in behavior:
run: ./gradlew on root level to build android tgz
run: ./gradlew runtests to run unit tests

ns-bot · 2017-12-18T08:51:00Z

💔

ns-bot · 2017-12-18T08:51:12Z

💔

ns-bot · 2017-12-18T09:03:46Z

💔

ns-bot · 2017-12-18T09:16:32Z

💔

Natalia-Hristova · 2017-12-18T11:42:54Z

run ci

ns-bot · 2017-12-18T11:43:32Z

💔

Natalia-Hristova · 2017-12-18T11:57:36Z

run ci

ns-bot · 2017-12-18T12:21:50Z

💔

ns-bot · 2017-12-18T12:22:34Z

💔

ns-bot · 2017-12-18T13:03:44Z

💔

ns-bot · 2017-12-18T14:09:58Z

💚

ns-bot · 2017-12-18T15:41:54Z

💚

ns-bot · 2017-12-18T15:57:45Z

💚

ns-bot · 2017-12-19T06:59:18Z

💔

ns-bot · 2017-12-19T07:19:43Z

💚

…with user template (#891)" This reverts commit 81f70ad.

* Revert "refactor(project template): replace runtime project template with user template (#891)" This reverts commit 81f70ad. * fix(tooling): wait for emulator before running adb commands * chore: update messages

Plamen5kov added 30 commits December 12, 2017 08:57

moved interface name generator into staticbinding generator

3e5da4c

moved static binding generator

6c2aece

renamed static binding generator

2b28fb1

moved android metadata generator

189b9b3

moved js parser to build tools

8b4bd07

moved tests [WIP] not working yet

d6ae37c

clean project template gradle

eae4739

update test-app build files

1f3e879

moved project template gradle to test-app

5c902ad

update metadata generator

715809b

update metadata generator gradle

f734615

update sbg build gradle

2be5de3

update sbg source

c4f026f

removed unnecessary files

53cdf17

removed unnecessary files

9246e26

updated jsparser

cdfbf45

update pack build gradle

6516332

added dts generator submodule

71cffce

deleted unnecessary files and moved jsparser tests

731d527

update submodules

d1e84c1

removed unnecessary code updated gitignore files

97bc27e

update build gradle to include compile subprojects compile depenencies

2c1327e

add sbg, mdg, dtg as provided dependencies

a0daddc

add generated files to git ignore

5b659e8

add generated files to git ignore

b9d6f93

added repository/description fields to js parser

47694bf

added npm install command to settings gradle for jsparser project

8dd110b

added empty package.json to tests so they're not traversed when sbg runs

835f763

removed generated files from source control

789f4a4

moved debug files to debug folder

738a728

Plamen5kov force-pushed the plamen5kov/project-structure-refactor branch from 6d243b8 to 8bf52e0 Compare December 18, 2017 09:03

Plamen5kov force-pushed the plamen5kov/project-structure-refactor branch from 8bf52e0 to 7e69283 Compare December 18, 2017 09:16

Plamen5kov added 2 commits December 18, 2017 14:55

fix(sbg): delete previously generated bindings file

440b29d

refactor(sbg tests): add shortcut to sbg tests and run by default

60541c3

Plamen5kov force-pushed the plamen5kov/project-structure-refactor branch from adf4597 to 60541c3 Compare December 18, 2017 12:55

refactor(user template): revert apk naiming because of CI

831480e

Plamen5kov force-pushed the plamen5kov/project-structure-refactor branch from fa2d9e5 to 9643e1e Compare December 18, 2017 15:47

chore(travis): conform to new build commands

3c7b72a

Plamen5kov force-pushed the plamen5kov/project-structure-refactor branch from 9643e1e to 3c7b72a Compare December 19, 2017 06:55

refactor(pack script): move tasks so they can be reused for tests

6003875

Plamen5kov merged commit 81f70ad into master Dec 19, 2017

Plamen5kov deleted the plamen5kov/project-structure-refactor branch December 19, 2017 07:39

petekanev added a commit that referenced this pull request Jan 4, 2018

Revert "refactor(project template): replace runtime project template …

9a5e4fc

…with user template (#891)" This reverts commit 81f70ad.

petekanev mentioned this pull request Jan 4, 2018

Revert "refactor(project template): replace runtime project template … #914

Closed

Uh oh!

refactor(project template): replace runtime project template with user template #891

refactor(project template): replace runtime project template with user template #891

Uh oh!

Conversation

Plamen5kov commented Dec 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

Natalia-Hristova commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

Natalia-Hristova commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 18, 2017

Uh oh!

ns-bot commented Dec 19, 2017

Uh oh!

ns-bot commented Dec 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Plamen5kov commented Dec 12, 2017 •

edited

Loading