Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdermendzhiev/wip f overloading protocol methods issue #1034

Conversation

tdermendjiev
Copy link
Contributor

@tdermendjiev tdermendjiev commented Dec 13, 2018

A separate PR for various fixes:
*ObjcExtends refactoring
*fix calling base class methods
*tests for ObjCPrototype.put and explicitly calling methods by BaseClass.call(instance)

src/NativeScript/ObjC/ObjCMethodCallback.h Outdated Show resolved Hide resolved
tests/TestRunner/app/ApiTests.js Outdated Show resolved Hide resolved
tests/TestRunner/app/ApiTests.js Outdated Show resolved Hide resolved
src/NativeScript/Metadata/Metadata.mm Outdated Show resolved Hide resolved
@tdermendjiev tdermendjiev force-pushed the tdermendzhiev/wip-f-overloading-protocol-methods-issue branch from b6f78f3 to d193920 Compare December 14, 2018 12:55
Copy link
Contributor

@mbektchiev mbektchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check whether we need to delete the addMethod function

src/NativeScript/ObjC/Inheritance/ObjCClassBuilder.h Outdated Show resolved Hide resolved
@tdermendjiev tdermendjiev force-pushed the tdermendzhiev/functions-overloading branch from a0eb1bc to df6103a Compare December 18, 2018 09:53
@tdermendjiev tdermendjiev force-pushed the tdermendzhiev/wip-f-overloading-protocol-methods-issue branch from d193920 to 94d0b71 Compare December 19, 2018 09:16
@tdermendjiev tdermendjiev force-pushed the tdermendzhiev/wip-f-overloading-protocol-methods-issue branch from 94d0b71 to 82aa0c0 Compare December 19, 2018 09:20
@tdermendjiev
Copy link
Contributor Author

test

@mbektchiev mbektchiev merged commit 99de71b into tdermendzhiev/functions-overloading Dec 20, 2018
@mbektchiev mbektchiev deleted the tdermendzhiev/wip-f-overloading-protocol-methods-issue branch December 20, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants