fix(webkit): Make JSC log to system logs instead of only to stderr #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdermendjiev
approved these changes
Mar 12, 2019
mbektchiev
force-pushed
the
bektchiev/jsc-logs-to-os_log
branch
2 times, most recently
from
aaa1286
to
8b69210
Compare
vtrifonov
approved these changes
Mar 12, 2019
Since the implementation of #1064 it has been made possible for {N} users to switch on different JSC diagnostic options. The problem was that to view the logs users had to use the Xcode debugger, because they weren't visible in the system logs and could not be captured by {N} CLI. With this change now all applications that retrieve system logs from the device will process them. We will also be able to add automated tests that ensure these options' correct functionality. related to #1004
mbektchiev
force-pushed
the
bektchiev/jsc-logs-to-os_log
branch
from
8b69210
to
95b9e8c
Compare
ghost
removed
the
mbektchiev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the implementation of #1064 it has been made possible
for {N} users to switch on different JSC diagnostic options.
The problem was that to view the logs users had to use the Xcode
debugger, because they weren't visible in the system logs and
could not be captured by {N} CLI. With this change now all
applications that retrieve system logs from the device will process
them. We will also be able to add automated tests that ensure
these options' correct functionality.
related to #1004
PR Checklist