Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return WrappedObject for classes with no meta #1125

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

vtrifonov
Copy link
Contributor

PR Checklist

What is the current behaviour?

When an Objective C class is read and there is no metadata for it we are getting the constructor from the first of its parents that have metadata.

What is the new behaviour?

When there's no metadata for a given Objective C class we are returning a wrapped object instead of it's parent constructor.

Related to #1120

@cla-bot cla-bot bot added the cla: yes label Apr 12, 2019
@vtrifonov vtrifonov added this to the 5.4.0 milestone Apr 12, 2019
@vtrifonov vtrifonov merged commit 3388b2c into master Apr 15, 2019
@vtrifonov vtrifonov deleted the trifonov/improve-class-resolving branch April 15, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants