Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): order not preserved #2261

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Sep 21, 2020

PR Checklist

What is the current behavior?

Ordering can be erratic when nesting ng-containers and templates. This is due to previousSibling not being implemented and comment nodes not being properly respected

<ng-container>
  <Label text="1" *ngIf="show"></Label>
  <Label text="2" *ngIf="show"></Label>
</ng-container>

will render:

2
1

What is the new behavior?

The node list is now doubly linked (previousSibling and nextSibling), allowing for faster processing of previousSibling and respecting the positioning of commentnodes.

<ng-container>
  <Label text="1" *ngIf="show"></Label>
  <Label text="2" *ngIf="show"></Label>
</ng-container>

will render
1
2

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Sep 21, 2020
@NathanWalker NathanWalker merged commit 07abb9e into NativeScript:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants