Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.2 issue: Custom ActionBar component with *ngIf on ActionItem will hide Custom title Label #897

Closed
NathanWalker opened this issue Jul 14, 2017 · 1 comment · Fixed by #903
Assignees
Labels

Comments

@NathanWalker
Copy link
Contributor

NathanWalker commented Jul 14, 2017

This is a rather interesting one. 3.1.1 works perfect, however this bug was introduced with 3.1.2 specifically.

Sample project:
https://github.com/NathanWalker/custom-title-3-1-2-issue

Repro steps:

  1. Run the app on iOS tns run ios --emulator
  2. Observe the title is blank in the ActionBar at top of opening page
  3. Open app/item/action-bar/action-bar.component.html
  4. Take note the usage of the custom Label for the title. Now comment out both ActionItem's (see note in file) below the Label.
  5. Observe the custom title Label will appear.

Bug:

Using custom Label title on a custom ActionBar component alongside ActionItem's with *ngIf will never work. This exact same setup worked perfectly in 3.1.1.

@tsonevn tsonevn added the bug label Jul 14, 2017
@mcrvaz
Copy link

mcrvaz commented Jul 17, 2017

My app logo is currently not showing with this setup:

<ActionBar title="" class="header">
            <StackLayout orientation="horizontal" horizontalAlignment="center">
                <Image [src]="currentLogo" class="logo"></Image>
            </StackLayout>
            <NavigationButton class="nav-button" *ngIf="showMenuButton" (tap)="toggleDrawer()"
                icon="res://ic_menu_black">
            </NavigationButton>
</ActionBar> 

Removing the *ngIf in the NavigationButton makes it work correctly.
Seems to be the same issue described here.

@sis0k0 sis0k0 self-assigned this Jul 18, 2017
vchimev pushed a commit to NativeScript/functional-tests that referenced this issue Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants